Deprecated RUNAI_VISIBLE_DEVICES key from GPU sharing configmap (#302)

Deprecated RUNAI_VISIBLE_DEVICES key from GPU sharing configmap

Author: romanbaron

CHANGELOG.md

@@ -6,6 +6,9 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/).
 
 ## [Unreleased]
 
+### Changed
+- Changed RUNAI-VISIBLE-DEVICES key in GPU sharing configmap to NVIDIA_VISIBLE_DEVICES
+
 ## [v0.7.3] - 2025-07-08
 
 ### Removed

pkg/binder/binding/default_binder_test.go

@@ -110,7 +110,7 @@ func TestBindApplyResourceReceivedType(t *testing.T) {
 							Name: common.NvidiaVisibleDevices,
 							ValueFrom: &v1.EnvVarSource{
 								ConfigMapKeyRef: &v1.ConfigMapKeySelector{
-									Key: common.VisibleDevices,
+									Key: common.NvidiaVisibleDevices,
 									LocalObjectReference: v1.LocalObjectReference{
 										Name: "my-config-0",
 									},

pkg/binder/binding/fraction_binder_test.go

@@ -216,7 +216,7 @@ var _ = Describe("FractionBinder", func() {
 				if err := fakeClient.Get(context.TODO(), client.ObjectKeyFromObject(configMap), configMap); err != nil {
 					Fail(fmt.Sprintf("Failed to read configmap: %v", err))
 				} else {
-					Expect(configMap.Data[common.VisibleDevices]).To(Equal(testData.gpuIndexByGroupIndex))
+					Expect(configMap.Data[common.NvidiaVisibleDevices]).To(Equal(testData.gpuIndexByGroupIndex))
 					Expect(configMap.Data[common.NumOfGpusEnvVar]).To(Equal("0.5"))
 				}
 			})

pkg/binder/common/constants.go

@@ -5,7 +5,6 @@ package common
 
 const (
 	NvidiaVisibleDevices = "NVIDIA_VISIBLE_DEVICES"
-	VisibleDevices       = "RUNAI-VISIBLE-DEVICES"
 	NumOfGpusEnvVar      = "RUNAI_NUM_OF_GPUS"
 	ReceivedTypeFraction = "Fraction"
 	ReceivedTypeRegular  = "Regular"

pkg/binder/common/gpu_access.go

@@ -15,12 +15,16 @@ import (
 	"github.com/NVIDIA/KAI-scheduler/pkg/binder/common/gpusharingconfigmap"
 )
 
+const (
+	visibleDevicesBC = "RUNAI-VISIBLE-DEVICES" // Deprecated, this value was replaced with NVIDIA_VISIBLE_DEVICES
+)
+
 func AddVisibleDevicesEnvVars(container *v1.Container, sharedGpuConfigMapName string) {
 	AddEnvVarToContainer(container, v1.EnvVar{
 		Name: NvidiaVisibleDevices,
 		ValueFrom: &v1.EnvVarSource{
 			ConfigMapKeyRef: &v1.ConfigMapKeySelector{
-				Key: VisibleDevices,
+				Key: NvidiaVisibleDevices,
 				LocalObjectReference: v1.LocalObjectReference{
 					Name: sharedGpuConfigMapName,
 				},
@@ -58,20 +62,19 @@ func SetNvidiaVisibleDevices(
 	var updateFunc func(data map[string]string) error
 	if nvidiaVisibleDevicesDefinedInSpec {
 		configMapName, err = gpusharingconfigmap.ExtractCapabilitiesConfigMapName(pod, containerRef)
-		updateFunc = func(data map[string]string) error {
-			data[VisibleDevices] = visibleDevicesValue
-			return nil
-		}
 	} else {
 		configMapName, err = gpusharingconfigmap.ExtractDirectEnvVarsConfigMapName(pod, containerRef)
-		updateFunc = func(data map[string]string) error {
-			data[NvidiaVisibleDevices] = visibleDevicesValue
-			return nil
-		}
 	}
 	if err != nil {
 		return err
 	}
+	updateFunc = func(data map[string]string) error {
+		if _, found := data[visibleDevicesBC]; found {
+			data[visibleDevicesBC] = visibleDevicesValue
+		}
+		data[NvidiaVisibleDevices] = visibleDevicesValue
+		return nil
+	}
 	err = UpdateConfigMapEnvironmentVariable(ctx, kubeClient, pod, configMapName, updateFunc)
 	if err != nil {
 		return fmt.Errorf("failed to update gpu sharing configmap %s for pod <%s/%s>: %v",