Remove check that the MinReplicas in each PodGroup of a PodGang need to be equal to the length of the PodReference slice. This allows auto-scaling to work at the Grove clique level (#293)

Signed-off-by: Sanjay Chatterjee <[email protected]>

Author: sanjaychatterjee

pkg/podgrouper/podgrouper/plugins/grove/grove_grouper.go

@@ -105,15 +105,6 @@ func (gg *GroveGrouper) GetPodGroupMetadata(
 			return nil, fmt.Errorf("missing podReferences in spec.podgroup[%v] of PodGang %s/%s",
 				idx, pod.Namespace, podGangName)
 		}
-		minReplicas, found, err := unstructured.NestedInt64(pgr, "minReplicas")
-		if err != nil {
-			return nil, fmt.Errorf("failed to get minReplicas from spec.podgroup[%v] of PodGang %s/%s : %w",
-				idx, pod.Namespace, podGangName, err)
-		}
-		if found && int(minReplicas) != len(podSlice) {
-			return nil, fmt.Errorf("unsupported minReplicas in spec.podgroup[%v] of PodGang %s/%s : expected: %v, found: %v",
-				idx, pod.Namespace, podGangName, len(podSlice), minReplicas)
-		}
 		minAvailable += int32(len(podSlice))
 	}
 	metadata.MinAvailable = minAvailable

pkg/podgrouper/podgrouper/plugins/grove/grove_grouper_test.go

@@ -132,69 +132,3 @@ func TestGetPodGroupMetadata(t *testing.T) {
 	assert.Equal(t, constants.InferencePriorityClass, metadata.PriorityClassName)
 	assert.Equal(t, "test_queue", metadata.Queue)
 }
-
-func TestErrorPodGroupMinReplicas(t *testing.T) {
-	podgang := &unstructured.Unstructured{
-		Object: map[string]interface{}{
-			"kind":       "PodGang",
-			"apiVersion": "scheduler.grove.io/v1alpha1",
-			"metadata": map[string]interface{}{
-				"name":      "pgs2",
-				"namespace": "test-ns",
-				"uid":       "2",
-				"labels": map[string]interface{}{
-					"test_label": "test_value",
-				},
-				"annotations": map[string]interface{}{
-					"test_annotation": "test_value",
-				},
-			},
-			"spec": map[string]interface{}{
-				"podgroups": []interface{}{
-					map[string]interface{}{
-						"podReferences": []interface{}{
-							map[string]interface{}{
-								"namespace": "test-ns",
-								"name":      "pgs1-pga1",
-							},
-							map[string]interface{}{
-								"namespace": "test-ns",
-								"name":      "pgs1-pga2",
-							},
-							map[string]interface{}{
-								"namespace": "test-ns",
-								"name":      "pgs1-pga3",
-							},
-							map[string]interface{}{
-								"namespace": "test-ns",
-								"name":      "pgs1-pga4",
-							},
-						},
-						"minReplicas": int64(2),
-					},
-				},
-				"priorityClassName": "inference",
-			},
-		},
-	}
-
-	pod := &v1.Pod{
-		TypeMeta: metav1.TypeMeta{},
-		ObjectMeta: metav1.ObjectMeta{
-			Name:      "pgs1-pga1",
-			Namespace: "test-ns",
-			Labels: map[string]string{
-				queueLabelKey:       "test_queue",
-				labelKeyPodGangName: "pgs2",
-			},
-			UID: "100",
-		},
-		Spec:   v1.PodSpec{},
-		Status: v1.PodStatus{},
-	}
-
-	client := fake.NewClientBuilder().WithScheme(scheme.Scheme).WithRuntimeObjects(podgang).Build()
-	grouper := NewGroveGrouper(client, defaultgrouper.NewDefaultGrouper(queueLabelKey, nodePoolLabelKey))
-	_, err := grouper.GetPodGroupMetadata(podgang, pod)
-	assert.EqualError(t, err, "unsupported minReplicas in spec.podgroup[0] of PodGang test-ns/pgs2 : expected: 4, found: 2")
-}