Removed runai-gpu-limit validation from binder (#284)

Author: romanbaron

pkg/binder/plugins/gpusharing/gpu-request/gpu_request_validator.go

@@ -21,7 +21,7 @@ func ValidateGpuRequests(pod *v1.Pod) error {
 	gpuFractionFromAnnotation, hasGpuFractionAnnotation := pod.Annotations[constants.GpuFraction]
 	gpuMemoryFromAnnotation, hasGpuMemoryAnnotation := pod.Annotations[constants.GpuMemory]
 	gpuFractionsCountFromAnnotation, hasGpuFractionsCount := pod.Annotations[constants.GpuFractionsNumDevices]
-	_, hasGpuLimitAnnotation := pod.Annotations[constants.GpuLimit]
+
 	mpsFromAnnotation, hasMpsAnnotation := pod.Annotations[constants.MpsAnnotation]
 	_, hasGpuResourceRequest := container.Resources.Requests[constants.GpuResource]
 	gpuLimitQuantity, hasGpuResourceLimit := container.Resources.Limits[constants.GpuResource]
@@ -46,10 +46,6 @@ func ValidateGpuRequests(pod *v1.Pod) error {
 		return fmt.Errorf("GPU is not not listed in resource limits")
 	}
 
-	if hasGpuLimitAnnotation && !isFractional {
-		return fmt.Errorf("cannot have GPU limit annotation without GPU fraction request")
-	}
-
 	if hasGpuResourceLimit && !isGpuFractionValid(hasWholeGPULimit, gpuLimitQuantity) {
 		return fmt.Errorf("GPU resource limit annotation cannot be larger than 1")
 	}

pkg/binder/plugins/gpusharing/gpu-request/gpu_request_validator_test.go

@@ -121,24 +121,6 @@ func TestValidateGpuRequests(t *testing.T) {
 			},
 			error: fmt.Errorf("GPU is not not listed in resource limits"),
 		},
-		{
-			name: "forbid fraction limit annotation without fraction request",
-			pod: &v1.Pod{
-				ObjectMeta: metav1.ObjectMeta{
-					Annotations: map[string]string{
-						constants.GpuLimit: "1",
-					},
-				},
-				Spec: v1.PodSpec{
-					Containers: []v1.Container{
-						{
-							Resources: v1.ResourceRequirements{},
-						},
-					},
-				},
-			},
-			error: fmt.Errorf("cannot have GPU limit annotation without GPU fraction request"),
-		},
 		{
 			name: "forbid fraction limit annotation without fraction request",
 			pod: &v1.Pod{

pkg/common/constants/constants.go

@@ -21,7 +21,6 @@ const (
 	GpuMemory                = "gpu-memory"
 	ReceivedResourceType     = "received-resource-type"
 	GpuFractionsNumDevices   = "gpu-fraction-num-devices"
-	GpuLimit                 = "runai-gpu-limit"
 	MpsAnnotation            = "mps"
 	StalePodgroupTimeStamp   = "kai.scheduler/stale-podgroup-timestamp"
 	LastStartTimeStamp       = "kai.scheduler/last-start-timestamp"