Skip to content

Commit 9cade65

Browse files
authored
feat(chart): Add flexible image tag configuration with priority-based overrides (#628)
* feat(chart): Add flexible image tag configuration with priority-based overrides * fix(values): Update comments to reflect correct versioning for image tag overrides * fix(values): Remove default image tag to enforce explicit configuration
1 parent 0f2ef2d commit 9cade65

File tree

4 files changed

+24
-13
lines changed

4 files changed

+24
-13
lines changed

deployments/kai-scheduler/templates/crd-upgrader.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ spec:
3030
{{- end }}
3131
containers:
3232
- name: upgrader
33-
image: "{{ .Values.global.registry }}/{{ .Values.crdupgrader.image.name }}:{{ .Chart.Version }}"
33+
image: "{{ .Values.global.registry }}/{{ .Values.crdupgrader.image.name }}:{{ .Values.crdupgrader.image.tag | default .Values.global.tag | default .Chart.AppVersion }}"
3434
imagePullPolicy: {{ .Values.crdupgrader.image.pullPolicy }}
3535
{{- if (lookup "apiextensions.k8s.io/v1" "CustomResourceDefinition" "" "clusterversions.config.openshift.io") }}
3636
securityContext:

deployments/kai-scheduler/templates/kai-config.yaml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ spec:
4646
image:
4747
name: {{ .Values.binder.image.name }}
4848
repository: {{ .Values.global.registry }}
49-
tag: {{ .Chart.Version }}
49+
tag: {{ .Values.binder.image.tag | default .Values.global.tag | default .Chart.AppVersion }}
5050
pullPolicy: {{ .Values.binder.image.pullPolicy | default .Values.global.imagePullPolicy }}
5151
{{- if .Values.binder.resources }}
5252
resources:
@@ -70,7 +70,7 @@ spec:
7070
image:
7171
name: {{ .Values.podgroupcontroller.image.name }}
7272
repository: {{ .Values.global.registry }}
73-
tag: {{ .Chart.Version }}
73+
tag: {{ .Values.podgroupcontroller.image.tag | default .Values.global.tag | default .Chart.AppVersion }}
7474
pullPolicy: {{ .Values.podgroupcontroller.image.pullPolicy | default .Values.global.imagePullPolicy }}
7575
{{- if .Values.podgroupcontroller.resources }}
7676
resources:
@@ -87,7 +87,7 @@ spec:
8787
image:
8888
name: {{ .Values.queuecontroller.image.name }}
8989
repository: {{ .Values.global.registry }}
90-
tag: {{ .Chart.Version }}
90+
tag: {{ .Values.queuecontroller.image.tag | default .Values.global.tag | default .Chart.AppVersion }}
9191
pullPolicy: {{ .Values.queuecontroller.image.pullPolicy | default .Values.global.imagePullPolicy }}
9292
{{- if .Values.queuecontroller.resources }}
9393
resources:
@@ -104,7 +104,7 @@ spec:
104104
image:
105105
name: {{ .Values.admission.image.name }}
106106
repository: {{ .Values.global.registry }}
107-
tag: {{ .Chart.Version }}
107+
tag: {{ .Values.admission.image.tag | default .Values.global.tag | default .Chart.AppVersion }}
108108
pullPolicy: {{ .Values.admission.image.pullPolicy | default .Values.global.imagePullPolicy }}
109109
{{- if .Values.admission.resources }}
110110
resources:
@@ -129,7 +129,7 @@ spec:
129129
image:
130130
name: {{ .Values.nodescaleadjuster.image.name }}
131131
repository: {{ .Values.global.registry }}
132-
tag: {{ .Chart.Version }}
132+
tag: {{ .Values.nodescaleadjuster.image.tag | default .Values.global.tag | default .Chart.AppVersion }}
133133
pullPolicy: {{ .Values.nodescaleadjuster.image.pullPolicy | default .Values.global.imagePullPolicy }}
134134
{{- if .Values.nodescaleadjuster.resources }}
135135
resources:
@@ -140,19 +140,19 @@ spec:
140140
{{- toYaml .Values.nodescaleadjuster.affinity | nindent 8 }}
141141
{{- end }}
142142
args:
143-
nodeScaleNamespace: {{ .Values.nodescaleadjuster.scalingPodNamespace }}
143+
nodeScaleNamespace: {{ .Values.nodescaleadjuster.scalingPodNamespace }}
144144
scalingPodImage:
145145
name: {{ .Values.nodescaleadjuster.scalingPodImage.name }}
146146
repository: {{ .Values.global.registry }}
147-
tag: {{ .Chart.Version }}
147+
tag: {{ .Values.nodescaleadjuster.scalingPodImage.tag | default .Values.global.tag | default .Chart.AppVersion }}
148148
pullPolicy: {{ .Values.nodescaleadjuster.scalingPodImage.pullPolicy | default .Values.global.imagePullPolicy }}
149149

150150
scheduler:
151151
service:
152152
image:
153153
name: {{ .Values.scheduler.image.name }}
154154
repository: {{ .Values.global.registry }}
155-
tag: {{ .Chart.Version }}
155+
tag: {{ .Values.scheduler.image.tag | default .Values.global.tag | default .Chart.AppVersion }}
156156
pullPolicy: {{ .Values.scheduler.image.pullPolicy | default .Values.global.imagePullPolicy }}
157157
{{- if .Values.scheduler.resources }}
158158
resources:

deployments/kai-scheduler/templates/services/operator.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ spec:
2121
serviceAccountName: kai-operator
2222
containers:
2323
- name: operator
24-
image: {{ .Values.global.registry }}/{{ .Values.operator.image.name }}:{{ .Chart.Version }}
24+
image: {{ .Values.global.registry }}/{{ .Values.operator.image.name }}:{{ .Values.operator.image.tag | default .Values.global.tag | default .Chart.AppVersion }}
2525
imagePullPolicy: {{ .Values.operator.image.pullPolicy }}
2626
{{- with .Values.operator.resources }}
2727
resources:
@@ -46,7 +46,7 @@ spec:
4646
- name: MS_REPOSITORY
4747
value: {{ .Values.global.registry }}
4848
- name: MS_TAG
49-
value: {{ .Chart.Version }}
49+
value: {{ .Values.operator.image.tag | default .Values.global.tag | default .Chart.AppVersion }}
5050
ports:
5151
- containerPort: 8080
5252
name: metrics

deployments/kai-scheduler/values.yaml

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44
global:
55
registry: registry/local/kai-scheduler
6-
tag: latest
6+
tag: ""
77
imagePullPolicy: IfNotPresent
88
securityContext: {}
99
imagePullSecrets: []
@@ -25,6 +25,7 @@ operator:
2525
image:
2626
name: operator
2727
pullPolicy: IfNotPresent
28+
# tag: "" # Optional: Override global.tag or Chart.AppVersion
2829
replicaCount: 1
2930
metricsBindAddress: ":8080"
3031
probeBindAddress: ":8081"
@@ -35,28 +36,33 @@ podgrouper:
3536
image:
3637
name: podgrouper
3738
pullPolicy: IfNotPresent
39+
# tag: "" # Optional: Override global.tag or Chart.AppVersion
3840
queueLabelKey: "kai.scheduler/queue"
3941
affinity: {}
4042

4143
podgroupcontroller:
4244
image:
4345
name: podgroupcontroller
4446
pullPolicy: IfNotPresent
47+
# tag: "" # Optional: Override global.tag or Chart.AppVersion
4548
affinity: {}
4649
binder:
4750
name: binder
4851
image:
4952
name: binder
5053
pullPolicy: IfNotPresent
54+
# tag: "" # Optional: Override global.tag or Chart.AppVersion
5155
resourceReservationImage:
5256
name: resourcereservation
57+
# tag: "" # Optional: Override global.tag or Chart.AppVersion
5358
ports:
5459
metricsPort: 8080
5560
affinity: {}
5661
scheduler:
5762
image:
5863
name: scheduler
5964
pullPolicy: IfNotPresent
65+
# tag: "" # Optional: Override global.tag or Chart.AppVersion
6066
placementStrategy: binpack
6167
ports:
6268
metricsPort: 8080
@@ -65,14 +71,16 @@ queuecontroller:
6571
image:
6672
name: queuecontroller
6773
pullPolicy: IfNotPresent
74+
# tag: "" # Optional: Override global.tag or Chart.AppVersion
6875
certSecretName: queuecontroller-webhook-tls-secret
69-
affinity: {}
76+
affinity: {}
7077

7178
admission:
7279
name: kai-admission
7380
image:
7481
name: admission
7582
pullPolicy: IfNotPresent
83+
# tag: "" # Optional: Override global.tag or Chart.AppVersion
7684
certSecretName: admission-webhook-tls-secret
7785
ports:
7886
webhookPort: 9443
@@ -86,16 +94,19 @@ nodescaleadjuster:
8694
image:
8795
name: nodescaleadjuster
8896
pullPolicy: IfNotPresent
97+
# tag: "" # Optional: Override global.tag or Chart.AppVersion
8998
scalingPodImage:
9099
name: scalingpod
91100
pullPolicy: IfNotPresent
101+
# tag: "" # Optional: Override global.tag or Chart.AppVersion
92102
scalingPodNamespace: kai-scale-adjust
93103
affinity: {}
94104

95105
crdupgrader:
96106
image:
97107
name: crd-upgrader
98108
pullPolicy: IfNotPresent
109+
# tag: "" # Optional: Override global.tag or Chart.AppVersion
99110

100111
defaultQueue:
101112
createDefaultQueue: true

0 commit comments

Comments
 (0)