Skip to content

Commit 7cd0616

Browse files
authored
Don't add nodepol label for empty nodepool (#183)
* Pre creating binding request, delete any pending status updates for the pod - cherrypick
1 parent d41ed17 commit 7cd0616

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

CHANGELOG.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,11 @@ All notable changes to this project will be documented in this file.
44

55
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/).
66

7-
## [v0.4.9]
7+
## [v0.4.9] - 2025-05-27
88

99
### Fixed
1010
- Fixed pod status scheduled race condition between the scheduler and the pod binding
11+
- Scheduler now doesn't label pods' nodepool when nodepool label value is empty
1112

1213
## [v0.4.8]
1314

pkg/scheduler/cache/cache.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -293,6 +293,9 @@ func (sc *SchedulerCache) nodePoolLabelsChange(currentLabels map[string]string)
293293
if sc.schedulingNodePoolParams.NodePoolLabelKey == "" {
294294
return labels
295295
}
296+
if sc.schedulingNodePoolParams.NodePoolLabelValue == "" {
297+
return labels
298+
}
296299
if value, found := currentLabels[sc.schedulingNodePoolParams.NodePoolLabelKey]; found && value == sc.schedulingNodePoolParams.NodePoolLabelValue {
297300
return labels
298301
}

0 commit comments

Comments
 (0)