Unitest fix - TestDefaultStatusUpdater_RecordJobStatusEvent (#232)

In the TestDefaultStatusUpdater_RecordJobStatusEvent unitest, set the right amout of calls for podGroup update waitGroup

Author: davidLif

pkg/scheduler/cache/status_updater/default_status_updater_test.go

@@ -503,11 +503,11 @@ func (r *SimpleRecorder) AnnotatedEventf(object runtime.Object, annotations map[
 
 func TestDefaultStatusUpdater_RecordJobStatusEvent(t *testing.T) {
 	tests := []struct {
-		name                      string
-		job                       jobs_fake.TestJobBasic
-		expectedEventActions      []string
-		expectedInFlightPodGroups int
-		expectedInFlightPods      int
+		name                          string
+		job                           jobs_fake.TestJobBasic
+		numPodGroupStatusUpdateCalled int
+		expectedEventActions          []string
+		expectedInFlightPodGroups     int
 	}{
 		{
 			name: "Running job",
@@ -525,7 +525,6 @@ func TestDefaultStatusUpdater_RecordJobStatusEvent(t *testing.T) {
 			},
 			expectedEventActions:      []string{},
 			expectedInFlightPodGroups: 1,
-			expectedInFlightPods:      0,
 		},
 		{
 			name: "No ready job",
@@ -543,7 +542,6 @@ func TestDefaultStatusUpdater_RecordJobStatusEvent(t *testing.T) {
 			},
 			expectedEventActions:      []string{"Normal NotReady Job is not ready for scheduling. Waiting for 2 pods, currently 1 exist, 0 are gated"},
 			expectedInFlightPodGroups: 0,
-			expectedInFlightPods:      0,
 		},
 		{
 			name: "Unscheduleable job",
@@ -559,9 +557,9 @@ func TestDefaultStatusUpdater_RecordJobStatusEvent(t *testing.T) {
 					},
 				},
 			},
-			expectedEventActions:      []string{"Warning Unschedulable Unable to schedule pod", "Normal Unschedulable Unable to schedule podgroup"},
-			expectedInFlightPodGroups: 1,
-			expectedInFlightPods:      1,
+			numPodGroupStatusUpdateCalled: 1,
+			expectedEventActions:          []string{"Warning Unschedulable Unable to schedule pod", "Normal Unschedulable Unable to schedule podgroup"},
+			expectedInFlightPodGroups:     1,
 		},
 	}
 	for _, test := range tests {
@@ -571,6 +569,9 @@ func TestDefaultStatusUpdater_RecordJobStatusEvent(t *testing.T) {
 			recorder := record.NewFakeRecorder(100)
 			statusUpdater := New(kubeClient, kubeAiSchedClient, recorder, 1, false, nodePoolLabelKey)
 			wg := sync.WaitGroup{}
+			if test.numPodGroupStatusUpdateCalled > 0 {
+				wg.Add(test.numPodGroupStatusUpdateCalled)
+			}
 			finishUpdatesChan := make(chan struct{})
 			// wait with pod groups update until signal is given.
 			kubeAiSchedClient.SchedulingV2alpha2().(*fakeschedulingv2alpha2.FakeSchedulingV2alpha2).PrependReactor(
@@ -600,12 +601,6 @@ func TestDefaultStatusUpdater_RecordJobStatusEvent(t *testing.T) {
 				return true
 			})
 			assert.Equal(t, test.expectedInFlightPodGroups, inFlightPodGroups)
-			inFlightPods := 0
-			statusUpdater.inFlightPods.Range(func(key, value any) bool {
-				inFlightPods += 1
-				return true
-			})
-			assert.Equal(t, test.expectedInFlightPods, inFlightPods)
 
 			close(finishUpdatesChan)
 			wg.Wait()