Triage tool deals with non-linear history #1538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

Steboss merged 55 commits into main from sbosisio/triage_history

Jul 15, 2025

Contributor

Steboss commented Jul 3, 2025

If commits do not lie on the same linear git history. The tool would use git fetch because it couldn't find a direct path between the passing and failing commits.
Here the changes introduce a new logic to find the correct bisection range:

apply git merge-base to identify common ancestors between the passing and failing commit
at build-and-run stage we're checking out the base commit from the main branch, and we apply cherry-pick for all new relevant features

Steboss and others added 4 commits

July 2, 2025 15:50


          update the triage tool to deal with non-linear history

2a920fb


          update changes

a179182


          fix args

e848e29


          Merge branch 'main' into sbosisio/triage_history

100b1b9

Steboss marked this pull request as draft

July 4, 2025 11:35

Steboss and others added 18 commits

July 4, 2025 12:38


          start drafting the test for the non-linear bisection

cf1345c


          fix the test and prepare for refactoring the main

259b4ac


          refactor main script in multiple ones and start testing

c6554e4


          save this version before testing it

acd5bb3


          fix argument

15ff577


          fix directory mount

6bdc74c


          finish off the testing with real examples

6bc0f85


          fix tests

c5f758e


          fix test with origin main

3ed49f2


          fix test and code, so we can avoid having feature-branch

fbc6faa


          fix initialization of package and create a more robust test

5845bfe


          create a test for the entire triage tool class

c053884


          remove previous test

e6334de


          Merge branch 'main' into sbosisio/triage_history

897dab5


          Ruff and MyPy fixes

883062f


          try to fix for python 3.8

f1a02d8


          try another way to pack dictionaries for 3.8

eb15191


          ruff fix

057f2d1

Steboss commented

View reviewed changes

.github/triage/jax_toolbox_triage/versions.py Show resolved Hide resolved

Steboss commented

View reviewed changes

.github/triage/jax_toolbox_triage/versions.py Show resolved Hide resolved

Steboss commented

View reviewed changes

.github/triage/jax_toolbox_triage/versions.py Show resolved Hide resolved

Steboss commented

View reviewed changes

.github/triage/jax_toolbox_triage/triage_tool.py Outdated Show resolved Hide resolved

Steboss commented

View reviewed changes

.github/triage/jax_toolbox_triage/triage_tool.py Show resolved Hide resolved

Steboss commented

View reviewed changes

.github/triage/jax_toolbox_triage/container_factory.py Show resolved Hide resolved

Steboss commented

View reviewed changes

.github/triage/jax_toolbox_triage/triage_tool.py Show resolved Hide resolved

Steboss and others added 12 commits

July 14, 2025 16:50


          Update .github/triage/tests/test_triage_history_bisection.py

4e56a73

Co-authored-by: Olli Lupton <[email protected]>


          Update .github/triage/tests/test_triage_history_bisection.py

7d760e4

Co-authored-by: Olli Lupton <[email protected]>


          Update .github/triage/tests/test_triage_history_bisection.py

08029c1

Co-authored-by: Olli Lupton <[email protected]>


          Update .github/triage/tests/test_triage_history_bisection.py

cd64936

Co-authored-by: Olli Lupton <[email protected]>


          Update .github/triage/tests/test_triage_history_bisection.py

43b4ce1

Co-authored-by: Olli Lupton <[email protected]>


          Update .github/triage/tests/test_triage_history_bisection.py

6d125aa

Co-authored-by: Olli Lupton <[email protected]>


          Update .github/triage/tests/test_triage_history_bisection.py

a974336

Co-authored-by: Olli Lupton <[email protected]>


          update tests for linear case, update output of triage tool

654d084


          Merge branch 'sbosisio/triage_history' of github.com:NVIDIA/JAX-Toolb…

f30fd5b

…ox into sbosisio/triage_history


          fix code with ruff and mypy

fc4abfb


          remove old test

9cd243c


          Merge branch 'main' into sbosisio/triage_history

d3db487

Steboss requested a review from olupton

July 15, 2025 10:57

Contributor Author

Steboss commented Jul 15, 2025

@olupton
re-ready for review
thank you 🙏

olupton reviewed

View reviewed changes

.github/triage/jax_toolbox_triage/bisect.py Outdated Show resolved Hide resolved

.github/triage/jax_toolbox_triage/bisect.py Outdated Show resolved Hide resolved

.github/triage/jax_toolbox_triage/bisect.py Outdated Show resolved Hide resolved

.github/triage/jax_toolbox_triage/triage_tool.py Outdated Show resolved Hide resolved

.github/triage/jax_toolbox_triage/triage_tool.py Outdated Show resolved Hide resolved

.github/triage/jax_toolbox_triage/triage_tool.py Outdated Show resolved Hide resolved

.github/triage/jax_toolbox_triage/summary.py Show resolved Hide resolved

.github/triage/jax_toolbox_triage/triage_tool.py Outdated Show resolved Hide resolved

.github/triage/tests/test_triage_history_bisection.py Outdated Show resolved Hide resolved

.github/triage/tests/test_triage_history_bisection.py Outdated Show resolved Hide resolved

Steboss and others added 11 commits

July 15, 2025 15:15


          Update .github/triage/jax_toolbox_triage/bisect.py

13c9c0c

Co-authored-by: Olli Lupton <[email protected]>


          Update .github/triage/jax_toolbox_triage/triage_tool.py

c791124

Co-authored-by: Olli Lupton <[email protected]>


          Update .github/triage/jax_toolbox_triage/triage_tool.py

9dcbaf1

Co-authored-by: Olli Lupton <[email protected]>


          Update .github/triage/jax_toolbox_triage/summary.py

e465499

Co-authored-by: Olli Lupton <[email protected]>


          Update .github/triage/jax_toolbox_triage/triage_tool.py

b07f960

Co-authored-by: Olli Lupton <[email protected]>


          Update .github/triage/tests/test_triage_history_bisection.py

48665b3

Co-authored-by: Olli Lupton <[email protected]>


          Update .github/triage/jax_toolbox_triage/bisect.py

881fa0b

Co-authored-by: Olli Lupton <[email protected]>


          fix errors and comments

729f4d9


          Merge branch 'sbosisio/triage_history' of github.com:NVIDIA/JAX-Toolb…

ed6da54

…ox into sbosisio/triage_history


          fix error

d6b4253


          fix @olupton comments

1e13d19

Contributor Author

Steboss commented Jul 15, 2025

@olupton
re-re-ready for a new review

olupton approved these changes

View reviewed changes

Collaborator

olupton left a comment

🚀

Steboss merged commit e5a1f2e into main

4 checks passed

Steboss deleted the sbosisio/triage_history branch

July 15, 2025 15:54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet