-
Notifications
You must be signed in to change notification settings - Fork 66
Max runtime for k8s job #1453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Max runtime for k8s job #1453
Conversation
|
@olupton I'd like to have your point of view on how to work out a solution here. |
olupton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the runtime limit can be added to .github/eks-workflow-files/mpi-nccl-test.yml too.
This seems like an improvement in principle. Did you do any experiments to make sure the error case handling actually works (e.g. run a job with the limit set to a tiny value)?
3 hours is a lot, but we might have to tune the value down in a second pass.
…nto sbosisio/k8s_orphan
|
@olupton |
This PR is a simple test: