Create an action for submit k8s and one for monitoring/deletion #1440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lbox into sbosisio/split_k8s_action
olupton
previously approved these changes
May 9, 2025
Contributor
Author
|
@olupton I can see that axlearn tests go on for 4-hours making other jobs out-of-time. |
olupton
reviewed
May 16, 2025
Comment on lines
+408
to
+409
| - name: Run Fuji on EKS | ||
| uses: ./.github/actions/run-job-k8s |
Collaborator
There was a problem hiding this comment.
Suggested change
| - name: Run Fuji on EKS | |
| uses: ./.github/actions/run-job-k8s | |
| - uses: ./.github/actions/run-job-k8s |
Comment on lines
+422
to
+423
| - name: Run Fuji on EKS | ||
| uses: ./.github/actions/run-job-k8s |
Collaborator
There was a problem hiding this comment.
Suggested change
| - name: Run Fuji on EKS | |
| uses: ./.github/actions/run-job-k8s | |
| - uses: ./.github/actions/run-job-k8s |
Comment on lines
+560
to
+561
| - name: Run Fuji on EKS | ||
| uses: ./.github/actions/run-job-k8s |
Collaborator
There was a problem hiding this comment.
Suggested change
| - name: Run Fuji on EKS | |
| uses: ./.github/actions/run-job-k8s | |
| - uses: ./.github/actions/run-job-k8s |
Comment on lines
+75
to
+76
| - name: Run Fuji on EKS | ||
| uses: ./.github/actions/run-job-k8s |
Collaborator
There was a problem hiding this comment.
Suggested change
| - name: Run Fuji on EKS | |
| uses: ./.github/actions/run-job-k8s | |
| - uses: ./.github/actions/run-job-k8s |
Comment on lines
+655
to
+656
| - name: Run Fuji on EKS | ||
| uses: ./.github/actions/run-job-k8s |
Collaborator
There was a problem hiding this comment.
Suggested change
| - name: Run Fuji on EKS | |
| uses: ./.github/actions/run-job-k8s | |
| - uses: ./.github/actions/run-job-k8s |
This one was actually what it said...but it seems that it overwrites the "Submit & delete K8s job" and "Monitor K8s job" parts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the
submit-delete-k8saction, and it splits in two different actions, one for submitting the job, and one for monitoring. In this way, we can have a full view on what's going on for wait and actual job running time.