Skip to content

Commit d506eef

Browse files
committed
Set GKE NCCL to use k8s secret action
1 parent c70b239 commit d506eef

File tree

1 file changed

+12
-0
lines changed

1 file changed

+12
-0
lines changed

.github/workflows/_test_nccl_gke.yaml

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,17 @@ jobs:
7272
7373
echo "WORKLOAD_PREFIX=${WORKLOAD_PREFIX}" >> ${GITHUB_OUTPUT}
7474
75+
- name: Login to GitHub Container Registry
76+
uses: docker/login-action@v3
77+
with:
78+
registry: ghcr.io
79+
username: ${{ github.repository_owner }}
80+
password: ${{ secrets.GITHUB_TOKEN }}
81+
82+
- name: Store registry secret on cluster
83+
id: store-token
84+
uses: ./.github/actions/store-delete-k8s-ghcr
85+
7586
- name: Create NCCL test Services on cluster
7687
run: |
7788
SERVICE_MANIFEST=".github/gke-workflow/nccl/service-${WORKLOAD_NAME}-${{ matrix.test }}.yaml"
@@ -86,6 +97,7 @@ jobs:
8697
with:
8798
IMAGE: ${{ env.BASE_IMAGE }}
8899
WORKLOAD_NAME_PREFIX: ${{ steps.workload-name.outputs.WORKLOAD_PREFIX }}
100+
IMAGE_PULL_SECRET_NAME: ${{ steps.store-token.outputs.token-name }}
89101
COMMAND: |
90102
export NHOSTS=${{ env.NHOSTS }};
91103
export NCCL_LIB_DIR=/opt/nvida/nccl/lib;

0 commit comments

Comments
 (0)