Skip to content

Commit 6d07ed4

Browse files
authored
Update the container labels in the integration tests (#1588)
We've recently changed the labels for the containers, as part of unifying the training and inference containers. This meant that certain container verification scripts were not getting run appropriately
1 parent fd2079b commit 6d07ed4

File tree

2 files changed

+11
-18
lines changed

2 files changed

+11
-18
lines changed

ci/test_integration.sh

Lines changed: 8 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,7 @@ set -e
1919

2020
# Call this script with:
2121
# 1. Name of container as first parameter
22-
# [merlin-training, merlin-tensorflow-training, merlin-pytorch-training,
23-
# merlin-inference, merlin-tensorflow-inference, merlin-pytorch-inference]
22+
# [merlin-hugectr, merlin-tensorflow, merlin-pytorch]
2423
#
2524
# 2. Devices to use:
2625
# [0; 0,1; 0,1,..,n-1]
@@ -33,25 +32,20 @@ container=$1
3332
config="-rsx --devices $2"
3433

3534
# Run tests for training containers
36-
regex="merlin(.)*-inference"
37-
if [[ ! "$container" =~ $regex ]]; then
38-
#pytest $config tests/integration/test_notebooks.py::test_criteo
39-
pytest $config tests/integration/test_notebooks.py::test_rossman
40-
pytest $config tests/integration/test_notebooks.py::test_movielens
41-
fi
35+
#pytest $config tests/integration/test_notebooks.py::test_criteo
36+
pytest $config tests/integration/test_notebooks.py::test_rossman
37+
pytest $config tests/integration/test_notebooks.py::test_movielens
4238

4339
# Run tests for specific containers
44-
if [ "$container" == "merlin-training" ]; then
40+
if [ "$container" == "merlin-hugectr" ]; then
4541
pytest $config tests/integration/test_nvt_hugectr.py::test_training
46-
elif [ "$container" == "merlin-tensorflow-training" ]; then
42+
pytest $config tests/integration/test_notebooks.py::test_criteo
43+
pytest $config tests/integration/test_nvt_hugectr.py::test_inference
44+
elif [ "$container" == "merlin-tensorflow" ]; then
4745
pytest $config tests/integration/test_nvt_tf_inference.py::test_nvt_tf_rossmann_inference
4846
pytest $config tests/integration/test_nvt_tf_inference.py::test_nvt_tf_movielens_inference
49-
elif [ "$container" == "merlin-tensorflow-inference" ]; then
5047
pytest $config tests/integration/test_nvt_tf_inference.py::test_nvt_tf_rossmann_inference_triton
5148
pytest $config tests/integration/test_nvt_tf_inference.py::test_nvt_tf_rossmann_inference_triton_mt
5249
pytest $config tests/integration/test_nvt_tf_inference.py::test_nvt_tf_movielens_inference_triton
5350
pytest $config tests/integration/test_nvt_tf_inference.py::test_nvt_tf_movielens_inference_triton_mt
54-
elif [ "$container" == "merlin-inference" ]; then
55-
pytest $config tests/integration/test_notebooks.py::test_criteo
56-
pytest $config tests/integration/test_nvt_hugectr.py::test_inference
5751
fi

tests/integration/test_notebooks.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -41,10 +41,9 @@
4141
MOVIELENS_DIR = "examples/getting-started-movielens"
4242

4343
allowed_hosts = [
44-
"merlin-training",
45-
"merlin-tensorflow-training",
46-
"merlin-torch-training",
47-
"merlin-inference",
44+
"merlin-hugectr",
45+
"merlin-tensorflow",
46+
"merlin-pytorch",
4847
]
4948

5049

0 commit comments

Comments
 (0)