Update imports for IOM expression type changes#5
Merged
Conversation
- Update test/Project.toml: add IOM and POM deps, remove HydroPowerSimulations and StorageSystemsSimulations - Update test/includes.jl: fix imports and aliases (POM=PowerOperationsModels, IOM=InfrastructureOptimizationModels) - Temporarily disable DCPPowerModel and ACPPowerModel tests pending PowerModelsExt integration - Fix PowerFlowsExt to use AbstractPowerFlowEvaluationData from IOM - Add JSON3 to Project.toml deps Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Rename InfrastructureModelsExt -> InfrastructureModels (not an extension) - Rename PowerModelsExt -> PowerModels (not an extension) - Include submodules in main PowerOperationsModels module - Add PM alias for PowerModels submodule - Add required dependencies (Memento, LinearAlgebra, Logging, SparseArrays) - Comment out AdmittanceMatrix functions (name clash with PNM) - Add missing exports: jump_value, ConstraintBounds, VariableBounds, DefaultDecisionProblem, DefaultEmulationProblem, Settings, InitialConditionsData, SimulationBuildStatus, COST_EPSILON, INITIALIZATION_PROBLEM_HORIZON_COUNT - Update documentation to reflect new structure Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
A package's test environment doesn't need the package itself as a dependency. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Companion changes to IOM's add_cost_to_expression! rename: - Import expression types (abstract and concrete) from IOM - Remove duplicate expression type definitions from expressions.jl - Remove TimeDurationOn/TimeDurationOff definitions (now in IOM) - Remove imports for functions not exported by IOM - Keep HVDCPowerBalance <: ConstraintType (separate from IOM's expression type) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
luke-kiernan
changed the title
Collaborator
Author
|
Oops: this PR builds on top of the other open one, just adds one additional commit. @jd-lara should I close the other one, or is it useful to have the changes segmented out like this? |
Implement device-specific initial condition methods that were moved from IOM: - Add initial_conditions/device_initial_conditions.jl with: - get_initial_conditions_value for InitialTimeDurationOn/Off (thermal) - add_initial_condition! for thermal generators with must_run handling - Add initial_conditions/update_initial_conditions.jl with: - update_initial_conditions! for all IC types (emulation model support) - Restore TimeDurationOn/TimeDurationOff definitions in auxiliary_variables.jl - Update imports to use new IOM exports Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Create add_to_expression.jl with device-specific implementations - Use renamed JuMP helpers from IOM (add_proportional_to_jump_expression!, etc.) - Consolidate and de-duplicate InfrastructureOptimizationModels imports - Remove constants from imports that POM defines locally Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
luke-kiernan
force-pushed
the
update-iom-expression-types
branch
from
ef98c58 to
1a02fda
Compare
All device-specific add_to_expression! implementations are now in PowerOperationsModels. IOM retains only add_expressions.jl with generic expression container setup and JuMP helpers. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Collaborator
Author
|
2.6k of the added lines of code here are directly copy-pasted from IOM's |
jd-lara
reviewed
Jan 27, 2026
jd-lara
reviewed
Jan 27, 2026
jd-lara
approved these changes
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
expressions.jlTimeDurationOn/TimeDurationOffdefinitions (now provided by IOM)HVDCPowerBalance <: ConstraintType(separate from IOM's expression type with the same name)Related PRs
Test plan
🤖 Generated with Claude Code