fix: keep site header on OAuth authorize and error pages - #129
Merged
Conversation
OAuth pages used layout: simple and a custom topbar, which replaced the global AppHeader. Drop that so authorize/error stay in the default layout without changing the site top bar.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
layout: simpleor render a customoauth-topbarAppHeaderis unchangedWhy
Recent OAuth UI work introduced a standalone simple layout and custom top bar, which replaced the site header. That was unintentional — these pages should not modify the page top bar.
Test plan
/app/oauth/authorize(with valid OAuth query params while logged in) and confirm the normal site header is present/app/oauth/errorand confirm the normal site header is present