Replacing PLOTUTILSROOT references

[smgilligan]

Need to find and replace instances of PLOTUTILSROOT with the environmental MATFLUXANDWEIGHTFILES.

[smgilligan]

Within MAT-MINERvA, grep -lir 'PLOTUTILSROOT' gives:

buildOSX/CMakeLists.txt
universes/GeantHadronSystematics.cxx
universes/MinervaUniverse.cxx
universes/GeantHadronSystematics.h
universes/MinervaUniverse.h
utilities/TargetUtils.cxx
weighters/MnvHadronReweight.cxx
README.md
CMakeLists.txt
setup.sh.in

Narrowing the search down to .h and .cxx files with grep -lir --include=*.h --include=*.cxx 'PLOTUTILSROOT' gives:

universes/GeantHadronSystematics.cxx
universes/MinervaUniverse.cxx
universes/GeantHadronSystematics.h
universes/MinervaUniverse.h
utilities/TargetUtils.cxx
weighters/MnvHadronReweight.cxx

The lines and context in particular are shown with grep -ir --include=*.h --include=*.cxx 'PLOTUTILSROOT', which gives:

universes/GeantHadronSystematics.cxx:    std::string directory = Form("%s/data/mhrwKineRenorm",getenv("PLOTUTILSROOT")) ){
universes/MinervaUniverse.cxx:std::string MinervaUniverse::m_mhrw_directory       = Form("%s/data/mhrwKineRenorm",getenv("PLOTUTILSROOT"));
universes/GeantHadronSystematics.h:           $PLOTUTILSROOT/data/mhrwKineRenorm, but the user may want to include
universes/MinervaUniverse.h:  static bool SetMHRWeightFilename( std::string process_name, std::string directory = Form("%s/data/mhrwKineRenorm",getenv("PLOTUTILSROOT")) );
utilities/TargetUtils.cxx:    const char* plotutils = gSystem->Getenv("PLOTUTILSROOT");
utilities/TargetUtils.cxx:        std::cout<<"$PLOTUTILSROOT is not set. Can't find flux histograms"<<std::endl;
weighters/MnvHadronReweight.cxx:    std::string plotutils = std::string(getenv("PLOTUTILSROOT"));
weighters/MnvHadronReweight.cxx:      std::cout<<"PlotUtils.MnvHadronReweight.XSecFunctions.loadTGraph: ERROR: $PLOTUTILSROOT is not defined"<<graphname<<std::endl;
weighters/MnvHadronReweight.cxx:  m_directory(Form("%s/data/mhrwKineRenorm",getenv("PLOTUTILSROOT"))),

Replacing PLOTUTILSROOT with MATFLUXANDWEIGHTFILES for the .h and .cxx files can be performed respectively with:

sed -i -e 's/PLOTUTILSROOT/MATFLUXANDWEIGHTFILES/g' */*.h
sed -i -e 's/PLOTUTILSROOT/MATFLUXANDWEIGHTFILES/g' */*.cxx

Afterwards, grep -ir --include=*.h --include=*.cxx 'PLOTUTILSROOT' gives nothing
and grep -ir --include=*.h --include=*.cxx 'MATFLUXANDWEIGHTFILES' gives:

universes/GeantHadronSystematics.cxx:    std::string directory = Form("%s/data/mhrwKineRenorm",getenv("MATFLUXANDWEIGHTFILES")) ){
universes/MinervaUniverse.cxx:std::string MinervaUniverse::m_mhrw_directory       = Form("%s/data/mhrwKineRenorm",getenv("MATFLUXANDWEIGHTFILES"));
universes/GeantHadronSystematics.h:           $MATFLUXANDWEIGHTFILES/data/mhrwKineRenorm, but the user may want to include
universes/MinervaUniverse.h:  static bool SetMHRWeightFilename( std::string process_name, std::string directory = Form("%s/data/mhrwKineRenorm",getenv("MATFLUXANDWEIGHTFILES")) );
utilities/TargetUtils.cxx:    const char* plotutils = gSystem->Getenv("MATFLUXANDWEIGHTFILES");
utilities/TargetUtils.cxx:        std::cout<<"$MATFLUXANDWEIGHTFILES is not set. Can't find flux histograms"<<std::endl;
weighters/MnvHadronReweight.cxx:    std::string plotutils = std::string(getenv("MATFLUXANDWEIGHTFILES"));
weighters/MnvHadronReweight.cxx:      std::cout<<"PlotUtils.MnvHadronReweight.XSecFunctions.loadTGraph: ERROR: $MATFLUXANDWEIGHTFILES is not defined"<<graphname<<std::endl;
weighters/MnvHadronReweight.cxx:  m_directory(Form("%s/data/mhrwKineRenorm",getenv("MATFLUXANDWEIGHTFILES"))),

Before making a commit and closing this issue I would like to verify whether or not any of the other files containing PLOTUTILSROOT need similar treatment. They are, as grep -lir 'PLOTUTILSROOT' now shows:

buildOSX/CMakeLists.txt
README.md
CMakeLists.txt
setup.sh.in

[hschellman]

We still need plotutilsroot in those non code areas. I’d use a branch,hen test, then do merge. On Sep 13, 2021, at 15:23, Sean Gilligan ***@***.***> wrote:  [This email originated from outside of OSU. Use caution with links and attachments.] Within MAT-MINERvA, grep -lir 'PLOTUTILSROOT' gives: buildOSX/CMakeLists.txt universes/GeantHadronSystematics.cxx universes/MinervaUniverse.cxx universes/GeantHadronSystematics.h universes/MinervaUniverse.h utilities/TargetUtils.cxx weighters/MnvHadronReweight.cxx README.md CMakeLists.txt setup.sh.in Narrowing the search down to .h and .cxx files with grep -lir --include=*.h --include=*.cxx 'PLOTUTILSROOT' gives: universes/GeantHadronSystematics.cxx universes/MinervaUniverse.cxx universes/GeantHadronSystematics.h universes/MinervaUniverse.h utilities/TargetUtils.cxx weighters/MnvHadronReweight.cxx The lines and context in particular are shown with grep -ir --include=*.h --include=*.cxx 'PLOTUTILSROOT', which gives: universes/GeantHadronSystematics.cxx: std::string directory = Form("%s/data/mhrwKineRenorm",getenv("PLOTUTILSROOT")) ){ universes/MinervaUniverse.cxx:std::string MinervaUniverse::m_mhrw_directory = Form("%s/data/mhrwKineRenorm",getenv("PLOTUTILSROOT")); universes/GeantHadronSystematics.h: $PLOTUTILSROOT/data/mhrwKineRenorm, but the user may want to include universes/MinervaUniverse.h: static bool SetMHRWeightFilename( std::string process_name, std::string directory = Form("%s/data/mhrwKineRenorm",getenv("PLOTUTILSROOT")) ); utilities/TargetUtils.cxx: const char* plotutils = gSystem->Getenv("PLOTUTILSROOT"); utilities/TargetUtils.cxx: std::cout<<"$PLOTUTILSROOT is not set. Can't find flux histograms"<<std::endl; weighters/MnvHadronReweight.cxx: std::string plotutils = std::string(getenv("PLOTUTILSROOT")); weighters/MnvHadronReweight.cxx: std::cout<<"PlotUtils.MnvHadronReweight.XSecFunctions.loadTGraph: ERROR: $PLOTUTILSROOT is not defined"<<graphname<<std::endl; weighters/MnvHadronReweight.cxx: m_directory(Form("%s/data/mhrwKineRenorm",getenv("PLOTUTILSROOT"))), Replacing PLOTUTILSROOT with MATFLUXANDWEIGHTFILES for the .h and .cxx files can be performed respectively with: sed -i -e 's/PLOTUTILSROOT/MATFLUXANDWEIGHTFILES/g' */*.h sed -i -e 's/PLOTUTILSROOT/MATFLUXANDWEIGHTFILES/g' */*.cxx Afterwards, grep -ir --include=*.h --include=*.cxx 'PLOTUTILSROOT' gives nothing and grep -ir --include=*.h --include=*.cxx 'MATFLUXANDWEIGHTFILES' gives: universes/GeantHadronSystematics.cxx: std::string directory = Form("%s/data/mhrwKineRenorm",getenv("MATFLUXANDWEIGHTFILES")) ){ universes/MinervaUniverse.cxx:std::string MinervaUniverse::m_mhrw_directory = Form("%s/data/mhrwKineRenorm",getenv("MATFLUXANDWEIGHTFILES")); universes/GeantHadronSystematics.h: $MATFLUXANDWEIGHTFILES/data/mhrwKineRenorm, but the user may want to include universes/MinervaUniverse.h: static bool SetMHRWeightFilename( std::string process_name, std::string directory = Form("%s/data/mhrwKineRenorm",getenv("MATFLUXANDWEIGHTFILES")) ); utilities/TargetUtils.cxx: const char* plotutils = gSystem->Getenv("MATFLUXANDWEIGHTFILES"); utilities/TargetUtils.cxx: std::cout<<"$MATFLUXANDWEIGHTFILES is not set. Can't find flux histograms"<<std::endl; weighters/MnvHadronReweight.cxx: std::string plotutils = std::string(getenv("MATFLUXANDWEIGHTFILES")); weighters/MnvHadronReweight.cxx: std::cout<<"PlotUtils.MnvHadronReweight.XSecFunctions.loadTGraph: ERROR: $MATFLUXANDWEIGHTFILES is not defined"<<graphname<<std::endl; weighters/MnvHadronReweight.cxx: m_directory(Form("%s/data/mhrwKineRenorm",getenv("MATFLUXANDWEIGHTFILES"))), Before making a commit and closing this issue I would like to verify whether or not any of the other files containing PLOTUTILSROOT need similar treatment. They are, as grep -lir 'PLOTUTILSROOT' now shows: buildOSX/CMakeLists.txt README.md CMakeLists.txt setup.sh.in — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub<https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMinervaExpt%2FMAT-MINERvA%2Fissues%2F2%23issuecomment-918627134&data=04%7C01%7Cheidi.schellman%40oregonstate.edu%7C4291a0bee0a843fc3f7908d977050bc1%7Cce6d05e13c5e4d6287a84c4a2713c113%7C0%7C0%7C637671685822201587%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=torNCS%2FGNr9XnS1uj%2FKFU8dh086Ul722oL5UIvfqpAg%3D&reserved=0>, or unsubscribe<https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAIA37DNHZNZHI2PC6QP7LADUBZ2UHANCNFSM5D6YDPIQ&data=04%7C01%7Cheidi.schellman%40oregonstate.edu%7C4291a0bee0a843fc3f7908d977050bc1%7Cce6d05e13c5e4d6287a84c4a2713c113%7C0%7C0%7C637671685822201587%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=%2B7wbYhbuwpk%2FSMIF0dnTcnMXFy9DpV6aG2Tu6dra8KM%3D&reserved=0>. Triage notifications on the go with GitHub Mobile for iOS<https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04%7C01%7Cheidi.schellman%40oregonstate.edu%7C4291a0bee0a843fc3f7908d977050bc1%7Cce6d05e13c5e4d6287a84c4a2713c113%7C0%7C0%7C637671685822211547%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=tJV1jZFKJTHgN4D5KlJC2UhVrLyEeUy7WMstOLxZsiw%3D&reserved=0> or Android<https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04%7C01%7Cheidi.schellman%40oregonstate.edu%7C4291a0bee0a843fc3f7908d977050bc1%7Cce6d05e13c5e4d6287a84c4a2713c113%7C0%7C0%7C637671685822211547%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=dUBXyvjPEmyl%2Bn4AVrMC5tEE%2FPh%2BHwwYzWJwJf8mpgA%3D&reserved=0>.

[smgilligan]

We still need plotutilsroot in those non code areas. I’d use a branch,hen test, then do merge.

On it.

[aolivier23]

When you're ready, I usually test by running the tutorial event loop. Running something with systematics from PickledCCQENu is just as good to me if that's easier for you. Thanks Sean.

[aolivier23]

GENIEXSecExtract also uses FluxReweighter. Once we've got an event loop working, we should check that package too. There's an easy test case for GENIEXSecExtract in the tutorial.