[JitDiff X64] [EgorBo] Use only 10 bytes of RNG in Guid.CreateVersion7 on Unix

[MihuBot]

Job completed in 16 minutes 55 seconds (remote runner delay: 1 minute 52 seconds).

Using arguments: -NoPRLink
Main commit: dotnet/runtime@553a1fe
PR commit: EgorBo/runtime-1@92dbf28

Diffs

Found 84 files with textual diffs.

Summary of Code Size diffs:
(Lower is better)

Total bytes of base: 46183090
Total bytes of diff: 46183529
Total bytes of delta: 439 (0.00 % of base)
Total relative delta: 1.31
    diff is a regression.
    relative diff is a regression.


Total byte diff includes 227 bytes from reconciling methods
	Base had    0 unique methods,        0 unique bytes
	Diff had    1 unique methods,      227 unique bytes

Top file regressions (bytes):
         439 : System.Private.CoreLib.dasm (0.01 % of base)

1 total files with Code Size differences (0 improved, 1 regressed), 259 unchanged.

Top method regressions (bytes):
         227 (Infinity of base) : System.Private.CoreLib.dasm - System.Guid:CreateVersion7Random():System.Guid (FullOpts) (0 base, 1 diff methods)
         212 (130.86 % of base) : System.Private.CoreLib.dasm - System.Guid:CreateVersion7(System.DateTimeOffset):System.Guid (FullOpts)

Top method regressions (percentages):
         227 (Infinity of base) : System.Private.CoreLib.dasm - System.Guid:CreateVersion7Random():System.Guid (FullOpts) (0 base, 1 diff methods)
         212 (130.86 % of base) : System.Private.CoreLib.dasm - System.Guid:CreateVersion7(System.DateTimeOffset):System.Guid (FullOpts)

2 total methods with Code Size differences (0 improved, 2 regressed), 287174 unchanged.

--------------------------------------------------------------------------------

Artifacts:

• jit-diffs-pr.zip (158 MB)
• jit-diffs-main.zip (158 MB)
• diff-frameworks.txt (1 KB)
• ShortDiffsRegressions.md (8 KB)

[MihuBot]

Top method regressions

212 (130.86 % of base) - System.Guid:CreateVersion7(System.DateTimeOffset):System.Guid

 ; Assembly listing for method System.Guid:CreateVersion7(System.DateTimeOffset):System.Guid (FullOpts)
 ; Emitting BLENDED_CODE for x64 + VEX + EVEX on Unix
 ; FullOpts code
 ; optimized code
 ; rbp based frame
 ; partially interruptible
 ; No PGO data
-; 0 inlinees with PGO data; 3 single block inlinees; 1 inlinees without PGO data
+; 0 inlinees with PGO data; 4 single block inlinees; 2 inlinees without PGO data
 ; Final local variable assignments
 ;
 ;* V00 arg0         [V00    ] (  0,  0   )  struct (16) zero-ref    multireg-arg ld-addr-op single-def <System.DateTimeOffset>
-;  V01 loc0         [V01,T00] (  8,  8   )  struct (16) [rbp-0x18]  do-not-enreg[SFRM] multireg-ret multireg-dest ld-addr-op <System.Guid>
-;  V02 loc1         [V02,T01] (  5,  4   )    long  ->  rdi        
+;  V01 loc0         [V01,T02] (  5,  4   )    long  ->  rbx        
+;  V02 loc1         [V02,T03] (  4,  4   )  struct (16) [rbp-0x38]  do-not-enreg[SFR] multireg-ret ld-addr-op <System.Guid>
 ;# V03 OutArgs      [V03    ] (  1,  1   )  struct ( 0) [rsp+0x00]  do-not-enreg[XS] addr-exposed "OutgoingArgSpace" <Empty>
-;  V04 tmp1         [V04,T04] (  1,  1   )     int  ->  rdi         single-def "field V00._offsetMinutes (fldOffset=0x0)" P-INDEP
-;  V05 tmp2         [V05,T03] (  2,  2   )    long  ->  rbx         single-def "field V00._dateTime (fldOffset=0x8)" P-INDEP
-;  V06 tmp3         [V06,T02] (  4,  4   )   short  ->  rax         "V01.[006..008)"
+;  V04 tmp1         [V04    ] (  3,  3   )  struct (16) [rbp-0x48]  do-not-enreg[XS] addr-exposed ld-addr-op "Inline ldloca(s) first use temp" <System.Guid>
+;* V05 tmp2         [V05    ] (  0,  0   )    long  ->  zero-ref    "Inlining Arg"
+;  V06 tmp3         [V06,T09] (  3,  0   )     ref  ->  rbx         class-hnd exact single-def "NewObj constructor temp" <System.Security.Cryptography.CryptographicException>
+;  V07 tmp4         [V07,T00] (  5, 10   )  struct (16) [rbp-0x58]  do-not-enreg[SR] multireg-ret "Single return block return value" <System.Guid>
+;  V08 FramesRoot   [V08,T01] (  6,  6   )    long  ->  r15         "Pinvoke FrameListRoot"
+;  V09 PInvokeFrame [V09    ] (  8,  8   )  struct (56) [rbp-0x90]  do-not-enreg[XS] addr-exposed "Pinvoke FrameVar" <UNNAMED>
+;  V10 tmp7         [V10,T06] (  1,  1   )     int  ->  rdi         single-def "field V00._offsetMinutes (fldOffset=0x0)" P-INDEP
+;  V11 tmp8         [V11,T05] (  2,  2   )    long  ->  rbx         single-def "field V00._dateTime (fldOffset=0x8)" P-INDEP
+;  V12 tmp9         [V12,T07] (  2,  2   )     int  ->  rdx         "V02.[000..004)"
+;  V13 tmp10        [V13,T08] (  2,  2   )   short  ->  rbx         "V02.[004..006)"
+;  V14 tmp11        [V14,T04] (  4,  4   )   short  ->  rax         "V02.[006..008)"
 ;
-; Lcl frame size = 24
+; Lcl frame size = 104
 
 G_M437_IG01:
        push     rbp
+       push     r15
+       push     r14
+       push     r13
+       push     r12
        push     rbx
-       sub      rsp, 24
-       lea      rbp, [rsp+0x20]
+       sub      rsp, 104
+       vzeroupper 
+       lea      rbp, [rsp+0x90]
        mov      rbx, rsi
-						;; size=14 bbWeight=1 PerfScore 3.00
+						;; size=28 bbWeight=1 PerfScore 8.00
 G_M437_IG02:
-       mov      rax, 0xD1FFAB1E      ; code for System.Guid:NewGuid():System.Guid
-       call     [rax]System.Guid:NewGuid():System.Guid
-       mov      qword ptr [rbp-0x18], rax
-       mov      qword ptr [rbp-0x10], rdx
+       lea      rdi, [rbp-0x90]
+       call     CORINFO_HELP_INIT_PINVOKE_FRAME
+       mov      r15, rax
+       mov      rdx, rsp
+       mov      qword ptr [rbp-0x78], rdx
+       mov      rdx, rbp
+       mov      qword ptr [rbp-0x68], rdx
        mov      rdx, 0xD1FFAB1E
-       mulx     rdi, rdi, rbx
-       shr      rdi, 11
-       mov      rax, 0xD1FFAB1E
-       add      rdi, rax
-       movsx    rax, word  ptr [rbp-0x12]
-       test     rdi, rdi
-       jl       SHORT G_M437_IG04
-       mov      rdx, rdi
+       mulx     rbx, rbx, rbx
+       shr      rbx, 11
+       mov      r14, 0xD1FFAB1E
+       add      rbx, r14
+       js       G_M437_IG08
+       lea      rdi, [rbp-0x42]
+       mov      esi, 10
+       mov      rax, 0xD1FFAB1E      ; function address
+       mov      qword ptr [rbp-0x80], rax
+       lea      rax, G_M437_IG05
+       mov      qword ptr [rbp-0x70], rax
+       lea      rax, [rbp-0x90]
+       mov      qword ptr [r15+0x08], rax
+       mov      byte  ptr [r15+0x04], 0
+						;; size=117 bbWeight=1 PerfScore 16.00
+G_M437_IG03:
+       mov      rax, 0xD1FFAB1E      ; code for Interop+Sys:GetCryptographicallySecureRandomBytes(ptr,int):int
+						;; size=10 bbWeight=1 PerfScore 0.25
+G_M437_IG04:
+       call     [rax]Interop+Sys:GetCryptographicallySecureRandomBytes(ptr,int):int
+						;; size=2 bbWeight=1 PerfScore 3.00
+G_M437_IG05:
+       mov      byte  ptr [r15+0x04], 1
+       mov      rcx, 0xD1FFAB1E      ; function address
+       cmp      dword ptr [rcx], 0
+       je       SHORT G_M437_IG06
+       mov      rdi, 0xD1FFAB1E
+       call     [rdi]CORINFO_HELP_STOP_FOR_GC
+						;; size=32 bbWeight=1 PerfScore 7.50
+G_M437_IG06:
+       mov      rdx, qword ptr [rbp-0x88]
+       mov      qword ptr [r15+0x08], rdx
+       test     eax, eax
+       jne      G_M437_IG09
+       movsx    rax, word  ptr [rbp-0x42]
+       mov      rdx, qword ptr [rbp-0x40]
+       mov      qword ptr [rbp-0x30], rdx
+       mov      rdx, rbx
        sar      rdx, 16
-       mov      dword ptr [rbp-0x18], edx
-       mov      word  ptr [rbp-0x14], di
+       movsx    rbx, bx
        and      eax, -0xF001
        or       eax, 0x7000
        cwde     
-       movzx    rdx, byte  ptr [rbp-0x10]
-       and      edx, -193
-       or       edx, 128
-       mov      byte  ptr [rbp-0x10], dl
-       mov      word  ptr [rbp-0x12], ax
-       mov      rax, qword ptr [rbp-0x18]
-       mov      rdx, qword ptr [rbp-0x10]
-						;; size=118 bbWeight=1 PerfScore 20.75
-G_M437_IG03:
-       add      rsp, 24
+       movzx    rdi, byte  ptr [rbp-0x30]
+       and      edi, -193
+       or       edi, 128
+       mov      byte  ptr [rbp-0x30], dil
+       mov      dword ptr [rbp-0x58], edx
+       mov      word  ptr [rbp-0x54], bx
+       mov      word  ptr [rbp-0x52], ax
+       mov      rax, qword ptr [rbp-0x30]
+       mov      qword ptr [rbp-0x50], rax
+       mov      rax, qword ptr [rbp-0x58]
+       mov      rdx, qword ptr [rbp-0x50]
+						;; size=102 bbWeight=1 PerfScore 17.50
+G_M437_IG07:
+       add      rsp, 104
        pop      rbx
+       pop      r12
+       pop      r13
+       pop      r14
+       pop      r15
        pop      rbp
        ret      
-						;; size=7 bbWeight=1 PerfScore 2.25
-G_M437_IG04:
+						;; size=15 bbWeight=1 PerfScore 4.25
+G_M437_IG08:
+       mov      rdi, rbx
        mov      rsi, 0xD1FFAB1E      ; 'timestamp'
        mov      rax, 0xD1FFAB1E      ; code for System.ArgumentOutOfRangeException:ThrowNegative[long](long,System.String)
        call     [rax]System.ArgumentOutOfRangeException:ThrowNegative[long](long,System.String)
        int3     
-						;; size=23 bbWeight=0 PerfScore 0.00
+						;; size=26 bbWeight=0 PerfScore 0.00
+G_M437_IG09:
+       mov      rdi, 0xD1FFAB1E      ; System.Security.Cryptography.CryptographicException
+       call     CORINFO_HELP_NEWSFAST
+       mov      rbx, rax
+       mov      rdi, rbx
+       mov      rax, 0xD1FFAB1E      ; code for System.Security.Cryptography.CryptographicException:.ctor():this
+       call     [rax]System.Security.Cryptography.CryptographicException:.ctor():this
+       mov      rdi, rbx
+       call     CORINFO_HELP_THROW
+       int3     
+						;; size=42 bbWeight=0 PerfScore 0.00
 
-; Total bytes of code 162, prolog size 11, PerfScore 26.00, instruction count 39, allocated bytes for code 162 (MethodHash=b782fe4a) for method System.Guid:CreateVersion7(System.DateTimeOffset):System.Guid (FullOpts)
+; Total bytes of code 374, prolog size 25, PerfScore 56.50, instruction count 86, allocated bytes for code 374 (MethodHash=b782fe4a) for method System.Guid:CreateVersion7(System.DateTimeOffset):System.Guid (FullOpts)
 ; ============================================================

[MihuBot]

@MihuBot