Skip to content

[✨ Triage] dotnet/aspire#10119 by AnKushSingh05 - Keyboard focus does not return to the parent control after closing ... #1164

Description

@MihuBot

Triage for microsoft/aspire#10119.
Repo filter: area-dashboard issues.
MihuBot version: a1770b.
Ping MihaZupan for any issues.

This is a test triage report generated by AI, aimed at helping the triage team quickly identify past issues/PRs that may be related.
Take any conclusions with a large grain of salt.

dotnet/aspire#10119: Keyboard focus does not return to the parent control after closing the Help, Github copilot and settings dialog: A11y_Aspire Dashboard_ResourcesFocusOrder. by AnKushSingh05
[Tool] Searching for keyboard focus dialog, focus does not return after closing dialog, A11y focus order, focus lost after closing Help dialog, focus lost after closing settings dialog, WCAG 2.4.3 focus Aspire Dashboard (IncludeOpen=True, IncludeClosed=True, IncludeIssues=True, IncludePullRequests=True, Repository=dotnet/aspire)
[Tool] Found 68 issues, 160 comments, 68 returned results (13240 ms)

Here are related issues and discussions relevant to issue #10119 ("Keyboard focus does not return to the parent control after closing the Help, Github copilot and settings dialog: A11y_Aspire Dashboard_ResourcesFocusOrder"):


Highly Relevant Issues

Issue #3362 (April 2024) - "When we close 'Details view' section focus moves to top of the page: A11y_.NetAspireDashboard_Resource_Details view_Keyboard"

  • Summary: Reported that after closing the "Details view" section, keyboard focus moves to the top of the page instead of returning to the "View" button. The issue was observed throughout the application.
  • Resolution: Fixed and verified by the reporter. The closing comment includes a video showing the bug is resolved.
  • Discussion: The fix was specifically for returning focus to the correct control after closing a panel/dialog.
  • Issue link

PR #3368 (April 2024) - "Re-focus view button when closing details panel"

  • Summary: This PR addressed the above issue by ensuring that focus returns to the "View" button when the details panel is closed, but only when the user explicitly dismisses the panel (not when it closes due to other actions like filtering).
  • Discussion: There was discussion about the correct scenarios for restoring focus, and the implementation was adjusted to only focus when the panel is explicitly dismissed by the user.
  • PR link

Issue #10127 (June 2025) - "Keyboard focus is coming out of the 'Copilot chat' dialog: A11y_Aspire Dashboard_Copilot_FocusOrder"

  • Summary: Focus is not being trapped within the "Copilot chat" dialog, allowing keyboard users to move focus outside the dialog.
  • Status: Open, no comments yet.
  • Issue link

Issue #10126 (June 2025) - "Unnecessary keyboard focus is being moved to the 'Help' heading: A11y_Aspire Dashboard_Help_Usability"

  • Summary: Focus is being set to a non-interactive heading in the Help dialog, which disrupts navigation for screen reader users.
  • Status: Open, no comments yet.
  • Issue link

Issue #10129 (June 2025) - "Unexpected backward focus navigation triggered by Shift + Tab: A11y_Aspire Dashboard_FocusOrder"

  • Summary: Shift+Tab causes unexpected focus navigation, which can disorient keyboard users.
  • Status: Open, no comments yet.
  • Issue link

Broader Context: Keyboard Focus and Dialogs

PR #2465 (February 2024) - "Untrack DialogReference when dialog is closed"

  • Summary: Fixed an issue where dialog references (for settings/help) were not cleared when dialogs were closed, which could affect dialog lifecycle and possibly focus management.
  • PR link

PR #2476 (February 2024) - "Use OnDialogClosing instead of OnDialogResult to remove dialog reference in MainLayout"

  • Summary: Improved dialog closing logic to ensure references are removed regardless of how the dialog is closed (e.g., clicking outside, pressing Escape).
  • PR link

General Accessibility and Focus Order Issues

Issue #3363 (April 2024) - "When we navigate using TAB key after the table keyboard focus moves to top of the page instead of moving to next interactive control"

  • Summary: Focus order issues after interacting with certain controls; fixed and verified.
  • Issue link
  • Summary: Keyboard navigation required extra steps to activate links; similar focus order/keyboard navigation concerns.
  • Issue link

Summary

  • There is a clear history of focus management and accessibility issues in the Aspire Dashboard, especially around dialogs and panels.
  • The most directly related resolved issue is #3362, which was fixed by ensuring focus returns to the correct control after closing a details panel. The associated PR #3368 contains discussion about only restoring focus when the user explicitly closes the panel/dialog.
  • Recent issues (June 2025) indicate that focus order and dialog focus trapping are still active areas of concern, especially for Help, Copilot, and Settings dialogs.
  • There have been infrastructure improvements to dialog lifecycle management (PRs #2465, #2476), which may impact focus restoration.

If you are triaging #10119, it is likely a regression or a new instance of a previously fixed pattern (as in #3362), but now affecting Help, Copilot, and Settings dialogs. It may require similar handling as was done for the details panel.

Let me know if you need a deeper dive into any specific issue or PR!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions