--nocolor complains about not enough colors

[egmontkob]

Is there an existing issue for this?

• I have searched the existing issues

Midnight Commander version and build configuration

4.8.33, git

Operating system

.

Is this issue reproducible using the latest version of Midnight Commander?

• I confirm the issue is still reproducible with the latest version of Midnight Commander

How to reproduce

Configure mc to use a skin that uses more colors than the terminal. E.g. mention xoria256 in the config file or pass --skin xoria256, whereas TERM=xterm and COLORTERM is unset. Or any similar setup.

If you start up mc, you get an error box explaining the mismatching color support situation, and mentioning that the default skin will be used. So far so good.

Now pass mc a -b a.k.a. --nocolor option.

Expected behavior

Start up in black and white, without the previous error dialog.

Actual behavior

The error dialog is still presented.

Additional context

No response

[egmontkob]

mc first loads the user's configured skin, then replaces the colors from the hardwired black-and-white skin.

For some reason, it's not a complete skin reload, it only affects the colors. Other properties (like line drawing chars) are still taken from the skin that otherwise failed to load.