Fix vertical line color if a file is marked and selected

[mc-butler]

Important

This issue was migrated from Trac:

Origin	https://midnight-commander.org/ticket/3417
Reporter	slavazanko (@slavaz)
Mentions	egmont@….com (@egmontkob)

Originally from: #54

I'm creating my own theme for mc and I noticed that the vertical lines (│) of marked and selected files they had the selected color instead of markselect.

Note

Original attachments:

• 54.patch (raw) by slavazanko (@slavaz) on Mar 19, 2015 at 8:44 UTC
• mc-3417.png (raw) by egmont (@egmontkob) on Mar 19, 2015 at 10:46 UTC
• mc_without_patch.png (raw) by oblique (psyberbits@….com) on Mar 19, 2015 at 12:01 UTC
• mc_with_patch.png (raw) by oblique (psyberbits@….com) on Mar 19, 2015 at 12:02 UTC

[mc-butler]

Changed by slavazanko (@slavaz) on Mar 19, 2015 at 8:44 UTC

• Attachment 54.patch (raw) added

[mc-butler]

Changed by slavazanko (@slavaz) on Mar 19, 2015 at 9:00 UTC (comment 1)

• Owner set to slavazanko
• Status changed from new to accepted

[mc-butler]

Changed by slavazanko (@slavaz) on Mar 19, 2015 at 9:17 UTC (comment 2)

• Votes set to slavazanko
• Branch state changed from no branch to approved

[mc-butler]

Changed by slavazanko (@slavaz) on Mar 19, 2015 at 9:20 UTC (comment 3)

• Resolution set to fixed
• Branch state changed from approved to merged
• Status changed from accepted to testing
• Votes changed from slavazanko to committed-master
• Milestone changed from Future Releases to 4.8.14
• Component changed from mc-core to mc-skin

Merged to master:

git log --pretty=oneline ada7f97...25d554a

[mc-butler]

Changed by slavazanko (@slavaz) on Mar 19, 2015 at 9:21 UTC (comment 4)

• Status changed from testing to closed

[mc-butler]

Changed by egmont (@egmontkob) on Mar 19, 2015 at 10:46 UTC

• Attachment mc-3417.png (raw) added

Regression

[mc-butler]

Changed by egmont (@egmontkob) on Mar 19, 2015 at 10:54 UTC (comment 5)

• Resolution fixed deleted
• Status changed from closed to reopened

Wow if only I could type 10 lines of text without the spam detection saying it's spam with 99.8%...

[mc-butler]

Changed by slavazanko (@slavaz) on Mar 19, 2015 at 12:00 UTC (comment 6)

Wow if only I could type 10 lines of text without the spam detection saying it's spam with 99.8%...

Sorry, it's crazy spam-filter :( I've trained the filter so I hope that you'll write comments without any restrictions

[mc-butler]

Changed by oblique (psyberbits@….com) on Mar 19, 2015 at 12:01 UTC

• Attachment mc_without_patch.png (raw) added

[mc-butler]

Changed by oblique (psyberbits@….com) on Mar 19, 2015 at 12:02 UTC

• Attachment mc_with_patch.png (raw) added

[mc-butler]

Changed by oblique (psyberbits@….com) on Mar 19, 2015 at 12:03 UTC (comment 7)

I don't think that is a regression. IMO the skin you are using is "buggy".

[mc-butler]

Changed by slavazanko (@slavaz) on Mar 19, 2015 at 12:07 UTC (comment 8)

I'm really not happy with this change, it breaks quite a few skins, including the default one with TERM=xterm (that is, 256 colors are *not* available and bold+bright is indeed bold). The result is quite ugly as the vertical bar changes to bold, and I don't like its foreground color change either. See the screenshot, it was taken with konsole. (Note: konsole hand-draws the line drawing characters and applies bold to them. The issue might not be visible with other terminals that either take these chars from the font (if the bold font doesn't actually make these bolder), or if the terminal hand-draws these chars but doesn't apply bold, such as gnome-terminal.)

Could you please revert the change (especially if a .14 release is due soon as I suspect)?

We should understand how the said skin wants to look like, and if necessary, maybe introduce a new color for that position and update the existing skins too.

Okay, I reverted these changes. See [cd04e91]

[mc-butler]

Changed by slavazanko (@slavaz) on Mar 19, 2015 at 12:13 UTC (comment 9)

• Milestone changed from 4.8.14 to 4.8.15

[mc-butler]

Changed by oblique (psyberbits@….com) on Mar 19, 2015 at 12:24 UTC (comment 10)

maybe introduce a new color for that position and update the existing skins too.

I like this solution.