Screen corruption after viewing UTF-8 file

[mc-butler]

Important

This issue was migrated from Trac:

Origin	https://midnight-commander.org/ticket/2453
Reporter	victor-homyakov (vkhomyackov@….com)

Empty place on file panel is sometimes corrupted with unicode symbols from viewed file. Steps to reproduce:

1. Make new empty directory on the left panel
2. Place into that directory attached file
3. View file (F3)
4. Close viewer(F3 again)

Some symbols from the file are left on the panel (see attached screenshots).

Note

Original attachments:

• google-chrome.desktop (raw) by victor-homyakov (vkhomyackov@….com) on Dec 20, 2010 at 9:20 UTC
• screenshot1.png (raw) by victor-homyakov (vkhomyackov@….com) on Dec 20, 2010 at 9:52 UTC
• screenshot2.png (raw) by victor-homyakov (vkhomyackov@….com) on Dec 20, 2010 at 10:21 UTC
• corruption.png (raw) by birdie (aros@….com) on Jan 30, 2011 at 22:52 UTC

[mc-butler]

Changed by victor-homyakov (vkhomyackov@….com) on Dec 20, 2010 at 9:20 UTC

• Attachment google-chrome.desktop (raw) added

This file causes panel corruption after closing viewer

[mc-butler]

Changed by andrew_b (@aborodin) on Dec 20, 2010 at 9:23 UTC (comment 1)

What is google-chrome.desktop?

[mc-butler]

Changed by andrew_b (@aborodin) on Dec 20, 2010 at 9:24 UTC (comment 1.2)

Replying to andrew_b:

What is google-chrome.desktop?

Аh. sorry... It is a test file.

[mc-butler]

Changed by victor-homyakov (vkhomyackov@….com) on Dec 20, 2010 at 9:52 UTC

• Attachment screenshot1.png (raw) added

Opened viewer

[mc-butler]

Changed by victor-homyakov (vkhomyackov@….com) on Dec 20, 2010 at 10:21 UTC

• Attachment screenshot2.png (raw) added

Corrupted panel

[mc-butler]

Changed by birdie (aros@….com) on Jan 30, 2011 at 22:52 UTC

• Attachment corruption.png (raw) added

[mc-butler]

Changed by birdie (aros@….com) on Jan 30, 2011 at 22:55 UTC (comment 1.3)

Replying to andrew_b:

What is google-chrome.desktop?

Just view any binary file - it corrupts the screen 100% of the time.

Pressing Ctrl + O twice resolves the problem.

However it seems like it's not strictly MC's issue, because I can reproduce it with a plain terminal session (see the attachment corruption.png):

$ cd /usr/bin
$ cat antiword.bin | head
press Ctrl + L

And what's more, pressing Ctrl + L in MC does nothing. So, it's probably not MC's bug at all.

[mc-butler]

Changed by andrew_b (@aborodin) on Jun 25, 2011 at 15:37 UTC (comment 4)

• Severity changed from no branch to on review
• Milestone changed from 4.8 to 4.8.0-pre1
• Owner set to andrew_b
• Status changed from new to accepted
• Keywords set to stable-candidate

As a solution, we can clear screen before redrawing panels.

Created 2453_screen_corruption patch (parent: master).
[580d273430e7f0d2d327c4ba164ea8b493c931df]

[mc-butler]

Changed by slavazanko (@slavaz) on Jul 6, 2011 at 11:20 UTC (comment 5)

• Votes set to slavazanko

[mc-butler]

Changed by angel_il (@ilia-maslakov) on Jul 7, 2011 at 13:34 UTC (comment 6)

• Severity changed from on review to approved
• Votes changed from slavazanko to slavazanko angel_il

[mc-butler]

Changed by slavazanko (@slavaz) on Jul 8, 2011 at 9:35 UTC (comment 7)

• Severity changed from approved to no branch
• Branch state set to approved

[mc-butler]

Changed by andrew_b (@aborodin) on Jul 8, 2011 at 9:53 UTC (comment 8)

• Resolution set to fixed
• Status changed from accepted to testing
• Branch state changed from approved to merged
• Votes changed from slavazanko angel_il to committed-master

Merged to master.
[f809e6c]

[mc-butler]

Changed by andrew_b (@aborodin) on Jul 9, 2011 at 16:45 UTC (comment 9)

• Resolution fixed deleted
• Status changed from testing to reopened

Reverted [f809e6c].
[1703365]

While navigating in main menu (from one submenu to another one) or after closing a dialog, the screen is blinking.

[mc-butler]

Changed by andrew_b (@aborodin) on Jul 9, 2011 at 16:46 UTC (comment 10)

• Votes committed-master deleted
• Milestone changed from 4.8.0-pre1 to 4.8
• Branch state changed from merged to no branch
• Keywords stable-candidate deleted