left/right arrow behavior inconsistent with "Cursor beyond end of line"

[mc-butler]

Important

This issue was migrated from Trac:

Origin	https://midnight-commander.org/ticket/1801
Reporter	ossi (@ossilator)

enabling "Cursor beyond end of line" stops the right-arrow from wrapping into the next line. however, the left-arrow continues to wrap to the previous line. this feels highly unnatural and often causes "navigation challenges". so enabling this option should make the left-arrow stop at the beginning of the line.

Note

Original attachments:

• 0001-don-t-allow-cursor-to-wrap-at-BOL-in-cursor_beyond_e.patch (raw) by ossi (@ossilator) on Oct 14, 2020 at 12:01 UTC

[mc-butler]

Changed by angel_il (@ilia-maslakov) on Nov 7, 2009 at 16:03 UTC (comment 1)

i think it's intuitive behaviour.

[mc-butler]

Changed by angel_il (@ilia-maslakov) on Dec 23, 2009 at 6:44 UTC (comment 2)

• Resolution set to wontfix
• Status changed from new to closed

[mc-butler]

Changed by ossi (@ossilator) on Dec 31, 2009 at 9:49 UTC (comment 3)

do you really *have* to be different than any other editor in use out there?

[mc-butler]

Changed by ossi (@ossilator) on Mar 9, 2010 at 7:48 UTC (comment 4)

i see that you copied that behavior from FAR, so it makes you different from every other editor BUT ONE. wow. what a remarkable precedent of braindamage ...

[mc-butler]

Changed by slavazanko (@slavaz) on Mar 9, 2010 at 22:03 UTC (comment 5)

i see that you copied that behavior from FAR, so it makes you different from every other
editor BUT ONE. wow. what a remarkable precedent of braindamage ...

You may switch off this behaviour:

• run mcedit
• F9 -> options -> general -> [ ] Cursor beyond end of line -> [< OK >]
• F9 -> options -> save setup

profit?

[mc-butler]

Changed by ossi (@ossilator) on Mar 9, 2010 at 22:32 UTC (comment 6)

no profit. you entirely missed the point.

--- a/src/editor/edit.c
+++ b/src/editor/edit.c
@@ -2128,8 +2128,11 @@ static void edit_left_char_move_cmd (WEdit * edit)
         if ( cw < 1 )
             cw = 1;
     }
-    if (option_cursor_beyond_eol && edit->over_col > 0) {
-        edit->over_col--;
+    if (option_cursor_beyond_eol) {
+        if (edit->over_col > 0)
+            edit->over_col--;
+        else if (edit->curs1 != edit_bol(edit, edit->curs1))
+            edit_cursor_move (edit, -cw);
     } else {
         edit_cursor_move (edit, -cw);
     }

[mc-butler]

Changed by angel_il (@ilia-maslakov) on Mar 10, 2010 at 6:08 UTC (comment 7)

• run mcedit
  • press home
  • F9 -> options -> general -> [ ] Cursor beyond end of line -> [< OK >]
  • F9 -> options -> save setup

profit? :)

and need fix trouble with 'over_col' you are right...

[mc-butler]

Changed by ossi (@ossilator) on Mar 10, 2010 at 21:06 UTC (comment 8)

sorry guys, are you a bit dense? do you understand what the patch does?

[mc-butler]

Changed by angel_il (@ilia-maslakov) on Mar 11, 2010 at 20:34 UTC (comment 9)

i'm so sorry, but i have not watched a patch, a lot of work on the my works... after the deadline, i see what's that.

[mc-butler]

Changed by angel_il (@ilia-maslakov) on Mar 11, 2010 at 20:46 UTC (comment 10)

• Status changed from closed to reopened
• Resolution wontfix deleted

[mc-butler]

Changed by angel_il (@ilia-maslakov) on Mar 19, 2010 at 6:09 UTC (comment 11)

• Status changed from reopened to closed
• Resolution set to wontfix

[mc-butler]

Changed by angel_il (@ilia-maslakov) on Mar 19, 2010 at 6:12 UTC (comment 12)

no profit. you entirely missed the point.

fixed in #2094

[mc-butler]

Changed by ossi (@ossilator) on Mar 19, 2010 at 7:44 UTC (comment 13)

• Status changed from closed to reopened
• Resolution wontfix deleted

no, not fixed. you still don't seem to understand what this is all about.

[mc-butler]

Changed by slavazanko (@slavaz) on Mar 19, 2010 at 7:57 UTC (comment 14)

Ossi, why you think, what cursor must wrap into the next line? Is this normal behavior? I think, current behavior very usefull for future feature 'drawing lines and boxes' (like it does good old MiltiEdit for DOS).

May be, need to add option info ini-file for change this behavior?... What you think?