fix: getCryptoApproveTransactionParams pricing from state (#6735)

## Explanation

<!--
Thanks for your contribution! Take a moment to answer these questions so
that reviewers have the information they need to properly understand
your changes:

* What is the current state of things and why does it need to change?
* What is the solution your changes offer and how does it work?
* Are there any changes whose purpose might not obvious to those
unfamiliar with the domain?
* If your primary goal was to update one package but you found you had
to update another one along the way, why did you do so?
* If you had to upgrade a dependency, why did you do so?
-->

Get pricing from state instead of fetching pricing from server in
`getCryptoApproveTransactionParams` since that method would be called
frequently by clients

## References

<!--
Are there any issues that this pull request is tied to?
Are there other links that reviewers should consult to understand these
changes better?
Are there client or consumer pull requests to adopt any breaking
changes?

For example:

* Fixes #12345
* Related to #67890
-->

## Checklist

- [x] I've updated the test suite for new or updated code as appropriate
- [x] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [x] I've communicated my changes to consumers by [updating changelogs
for packages I've
changed](https://github.com/MetaMask/core/tree/main/docs/contributing.md#updating-changelogs),
highlighting breaking changes as necessary
- [x] I've prepared draft pull requests for clients and consumer
packages to resolve any breaking changes

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> Use cached `state.pricing` in `getCryptoApproveTransactionParams`
(with new missing-pricing error) and add/register/export the
`getBillingPortalUrl` messaging action; update tests and changelog.
> 
> - **SubscriptionController**:
> - Use `state.pricing` in `getCryptoApproveTransactionParams` instead
of fetching; throw `Subscription pricing not found` if absent.
> - Register new action handler
`SubscriptionController:getBillingPortalUrl`.
> - **Exports**:
> - Export `SubscriptionControllerGetBillingPortalUrlAction`,
`AllowedActions`, and `AllowedEvents` in `src/index.ts`.
> - **Tests**:
> - Update `getCryptoApproveTransactionParams` tests to seed
`state.pricing` and add case for missing pricing.
> - **Changelog**:
> - Note change to read pricing from state in
`getCryptoApproveTransactionParams`.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
b70ee72. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

---------

Co-authored-by: Chaitanya Potti <[email protected]>

Author: tuna1207

packages/subscription-controller/CHANGELOG.md

@@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Changed
 
+- Get pricing from state instead of fetching pricing from server in `getCryptoApproveTransactionParams` ([#6735](https://github.com/MetaMask/core/pull/6735))
 - Bump `@metamask/utils` from `^11.8.0` to `^11.8.1` ([#6708](https://github.com/MetaMask/core/pull/6708))
 
 ## [0.4.0]

packages/subscription-controller/src/SubscriptionController.test.ts

@@ -759,176 +759,223 @@ describe('SubscriptionController', () => {
 
   describe('getCryptoApproveTransactionParams', () => {
     it('returns transaction params for crypto approve transaction', async () => {
-      await withController(async ({ controller, mockService }) => {
-        // Provide product pricing and crypto payment info with unitDecimals small to avoid integer div to 0
-        mockService.getPricing.mockResolvedValue(MOCK_PRICE_INFO_RESPONSE);
-
-        const result = await controller.getCryptoApproveTransactionParams({
-          chainId: '0x1',
-          paymentTokenAddress: '0xtoken',
-          productType: PRODUCT_TYPES.SHIELD,
-          interval: RECURRING_INTERVALS.month,
-        });
+      await withController(
+        {
+          state: {
+            pricing: MOCK_PRICE_INFO_RESPONSE,
+          },
+        },
+        async ({ controller }) => {
+          const result = await controller.getCryptoApproveTransactionParams({
+            chainId: '0x1',
+            paymentTokenAddress: '0xtoken',
+            productType: PRODUCT_TYPES.SHIELD,
+            interval: RECURRING_INTERVALS.month,
+          });
 
-        expect(result).toStrictEqual({
-          approveAmount: '9000000000000000000',
-          paymentAddress: '0xspender',
-          paymentTokenAddress: '0xtoken',
-          chainId: '0x1',
-        });
-      });
+          expect(result).toStrictEqual({
+            approveAmount: '9000000000000000000',
+            paymentAddress: '0xspender',
+            paymentTokenAddress: '0xtoken',
+            chainId: '0x1',
+          });
+        },
+      );
     });
 
-    it('throws when product price not found', async () => {
-      await withController(async ({ controller, mockService }) => {
-        mockService.getPricing.mockResolvedValue({
-          products: [],
-          paymentMethods: [],
-        });
-
+    it('throws when pricing not found', async () => {
+      await withController(async ({ controller }) => {
         await expect(
           controller.getCryptoApproveTransactionParams({
             chainId: '0x1',
             paymentTokenAddress: '0xtoken',
             productType: PRODUCT_TYPES.SHIELD,
             interval: RECURRING_INTERVALS.month,
           }),
-        ).rejects.toThrow('Product price not found');
+        ).rejects.toThrow('Subscription pricing not found');
       });
     });
 
+    it('throws when product price not found', async () => {
+      await withController(
+        {
+          state: {
+            pricing: {
+              products: [],
+              paymentMethods: [],
+            },
+          },
+        },
+        async ({ controller }) => {
+          await expect(
+            controller.getCryptoApproveTransactionParams({
+              chainId: '0x1',
+              paymentTokenAddress: '0xtoken',
+              productType: PRODUCT_TYPES.SHIELD,
+              interval: RECURRING_INTERVALS.month,
+            }),
+          ).rejects.toThrow('Product price not found');
+        },
+      );
+    });
+
     it('throws when price not found for interval', async () => {
-      await withController(async ({ controller, mockService }) => {
-        mockService.getPricing.mockResolvedValue({
-          products: [
-            {
-              name: PRODUCT_TYPES.SHIELD,
-              prices: [
+      await withController(
+        {
+          state: {
+            pricing: {
+              products: [
                 {
-                  interval: RECURRING_INTERVALS.year,
-                  currency: 'usd',
-                  unitAmount: 10,
-                  unitDecimals: 18,
-                  trialPeriodDays: 0,
-                  minBillingCycles: 1,
+                  name: PRODUCT_TYPES.SHIELD,
+                  prices: [
+                    {
+                      interval: RECURRING_INTERVALS.year,
+                      currency: 'usd',
+                      unitAmount: 10,
+                      unitDecimals: 18,
+                      trialPeriodDays: 0,
+                      minBillingCycles: 1,
+                    },
+                  ],
                 },
               ],
+              paymentMethods: [],
             },
-          ],
-          paymentMethods: [],
-        });
-
-        await expect(
-          controller.getCryptoApproveTransactionParams({
-            chainId: '0x1',
-            paymentTokenAddress: '0xtoken',
-            productType: PRODUCT_TYPES.SHIELD,
-            interval: RECURRING_INTERVALS.month,
-          }),
-        ).rejects.toThrow('Price not found');
-      });
+          },
+        },
+        async ({ controller }) => {
+          await expect(
+            controller.getCryptoApproveTransactionParams({
+              chainId: '0x1',
+              paymentTokenAddress: '0xtoken',
+              productType: PRODUCT_TYPES.SHIELD,
+              interval: RECURRING_INTERVALS.month,
+            }),
+          ).rejects.toThrow('Price not found');
+        },
+      );
     });
 
     it('throws when chains payment info not found', async () => {
-      await withController(async ({ controller, mockService }) => {
-        mockService.getPricing.mockResolvedValue({
-          ...MOCK_PRICE_INFO_RESPONSE,
-          paymentMethods: [
-            {
-              type: PAYMENT_TYPES.byCard,
+      await withController(
+        {
+          state: {
+            pricing: {
+              ...MOCK_PRICE_INFO_RESPONSE,
+              paymentMethods: [
+                {
+                  type: PAYMENT_TYPES.byCard,
+                },
+              ],
             },
-          ],
-        });
-
-        await expect(
-          controller.getCryptoApproveTransactionParams({
-            chainId: '0x1',
-            paymentTokenAddress: '0xtoken',
-            productType: PRODUCT_TYPES.SHIELD,
-            interval: RECURRING_INTERVALS.month,
-          }),
-        ).rejects.toThrow('Chains payment info not found');
-      });
+          },
+        },
+        async ({ controller }) => {
+          await expect(
+            controller.getCryptoApproveTransactionParams({
+              chainId: '0x1',
+              paymentTokenAddress: '0xtoken',
+              productType: PRODUCT_TYPES.SHIELD,
+              interval: RECURRING_INTERVALS.month,
+            }),
+          ).rejects.toThrow('Chains payment info not found');
+        },
+      );
     });
 
     it('throws when invalid chain id', async () => {
-      await withController(async ({ controller, mockService }) => {
-        mockService.getPricing.mockResolvedValue({
-          ...MOCK_PRICE_INFO_RESPONSE,
-          paymentMethods: [
-            {
-              type: PAYMENT_TYPES.byCrypto,
-              chains: [
+      await withController(
+        {
+          state: {
+            pricing: {
+              ...MOCK_PRICE_INFO_RESPONSE,
+              paymentMethods: [
                 {
-                  chainId: '0x2',
-                  paymentAddress: '0xspender',
-                  tokens: [],
+                  type: PAYMENT_TYPES.byCrypto,
+                  chains: [
+                    {
+                      chainId: '0x2',
+                      paymentAddress: '0xspender',
+                      tokens: [],
+                    },
+                  ],
                 },
               ],
             },
-          ],
-        });
-
-        await expect(
-          controller.getCryptoApproveTransactionParams({
-            chainId: '0x1',
-            paymentTokenAddress: '0xtoken',
-            productType: PRODUCT_TYPES.SHIELD,
-            interval: RECURRING_INTERVALS.month,
-          }),
-        ).rejects.toThrow('Invalid chain id');
-      });
+          },
+        },
+        async ({ controller }) => {
+          await expect(
+            controller.getCryptoApproveTransactionParams({
+              chainId: '0x1',
+              paymentTokenAddress: '0xtoken',
+              productType: PRODUCT_TYPES.SHIELD,
+              interval: RECURRING_INTERVALS.month,
+            }),
+          ).rejects.toThrow('Invalid chain id');
+        },
+      );
     });
 
     it('throws when invalid token address', async () => {
-      await withController(async ({ controller, mockService }) => {
-        mockService.getPricing.mockResolvedValue(MOCK_PRICE_INFO_RESPONSE);
-
-        await expect(
-          controller.getCryptoApproveTransactionParams({
-            chainId: '0x1',
-            paymentTokenAddress: '0xtoken-invalid',
-            productType: PRODUCT_TYPES.SHIELD,
-            interval: RECURRING_INTERVALS.month,
-          }),
-        ).rejects.toThrow('Invalid token address');
-      });
+      await withController(
+        {
+          state: {
+            pricing: MOCK_PRICE_INFO_RESPONSE,
+          },
+        },
+        async ({ controller }) => {
+          await expect(
+            controller.getCryptoApproveTransactionParams({
+              chainId: '0x1',
+              paymentTokenAddress: '0xtoken-invalid',
+              productType: PRODUCT_TYPES.SHIELD,
+              interval: RECURRING_INTERVALS.month,
+            }),
+          ).rejects.toThrow('Invalid token address');
+        },
+      );
     });
 
     it('throws when conversion rate not found', async () => {
-      await withController(async ({ controller, mockService }) => {
-        // Valid product and chain/token, but token lacks conversion rate for currency
-        mockService.getPricing.mockResolvedValue({
-          ...MOCK_PRICE_INFO_RESPONSE,
-          paymentMethods: [
-            {
-              type: PAYMENT_TYPES.byCrypto,
-              chains: [
+      await withController(
+        {
+          state: {
+            pricing: {
+              ...MOCK_PRICE_INFO_RESPONSE,
+              paymentMethods: [
                 {
-                  chainId: '0x1',
-                  paymentAddress: '0xspender',
-                  tokens: [
+                  type: PAYMENT_TYPES.byCrypto,
+                  chains: [
                     {
-                      address: '0xtoken',
-                      decimals: 18,
-                      conversionRate: {},
+                      chainId: '0x1',
+                      paymentAddress: '0xspender',
+                      tokens: [
+                        {
+                          address: '0xtoken',
+                          decimals: 18,
+                          symbol: 'USDT',
+                          conversionRate: {} as { usd: string },
+                        },
+                      ],
                     },
                   ],
                 },
               ],
             },
-          ],
-        });
-
-        await expect(
-          controller.getCryptoApproveTransactionParams({
-            chainId: '0x1',
-            paymentTokenAddress: '0xtoken',
-            productType: PRODUCT_TYPES.SHIELD,
-            interval: RECURRING_INTERVALS.month,
-          }),
-        ).rejects.toThrow('Conversion rate not found');
-      });
+          },
+        },
+        async ({ controller }) => {
+          await expect(
+            controller.getCryptoApproveTransactionParams({
+              chainId: '0x1',
+              paymentTokenAddress: '0xtoken',
+              productType: PRODUCT_TYPES.SHIELD,
+              interval: RECURRING_INTERVALS.month,
+            }),
+          ).rejects.toThrow('Conversion rate not found');
+        },
+      );
     });
   });