Apply suggestions from code review

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Author: MarcelGeo

mergin/client_pull.py

@@ -25,8 +25,8 @@
 from .common import CHUNK_SIZE, ClientError, DeltaChangeType, PullActionType
 from .models import ProjectDelta, ProjectDeltaChange, PullAction
 from .merginproject import MerginProject
-from .utils import cleanup_tmp_dir, int_version, save_to_file
-from typing import List, Optional, Tuple
+from .utils import cleanup_tmp_dir, save_to_file
+from typing import List, Optional
 
 # status = download_project_async(...)
 #

mergin/merginproject.py

@@ -9,7 +9,7 @@
 import tempfile
 from datetime import datetime
 from dateutil.tz import tzlocal
-from dataclasses import asdict
+
 
 from .editor import prevent_conflicted_copy
 
@@ -644,7 +644,7 @@ def get_local_delta(self, diff_directory: str) -> List[ProjectDeltaChange]:
                 self.log.warning("failed to create changeset for " + path)
                 # probably the database schema has been modified if geodiff cannot create changeset.
                 # we will need to do full upload of the file
-                pass
+
             result.append(delta_item)
 
         return result

mergin/test/test_client.py

@@ -613,7 +613,7 @@ def test_sync_diff(mc):
     project_info = mc.project_info_v2(mp.project_id(), mp.version())
     assert project_info.version == "v3"
     assert project_info.id == mp.project_id()
-    f_remote = next((f for f in project_info.files if f.path == f_updated), None)
+
     assert next((f for f in project_info.files if f.path == "renamed.gpkg"), None)
     assert not next((f for f in project_info.files if f.path == f_removed), None)
     assert not os.path.exists(mp.fpath_meta(f_removed))

mergin/test/test_client_pull.py

@@ -32,12 +32,12 @@ def test_get_diff_download_files():
         assert f2.downloaded_items[0].version == "v2"
 
 
-@pytest.fixture
 def test_get_download_items():
     with tempfile.TemporaryDirectory() as tmp_dir:
         # Case 1: Small file (one chunk)
         items = get_download_items("small.txt", 100, "v1", tmp_dir)
         assert len(items) == 1
+        assert len(items) == 1
         assert items[0].file_path == "small.txt"
         assert items[0].size == 100
         assert items[0].part_index == 0