Skip to content

Conversation

@heyvister1
Copy link
Collaborator

@heyvister1 heyvister1 commented Oct 20, 2025

@github-actions
Copy link

Thanks for your PR,
To run vendors CIs, Maintainers can use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs, Maintainers can use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@coveralls
Copy link

coveralls commented Oct 20, 2025

Pull Request Test Coverage Report for Build 18673535528

Details

  • 11 of 22 (50.0%) changed or added relevant lines in 4 files are covered.
  • 8 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.05%) to 61.975%

Changes Missing Coverage Covered Lines Changed/Added Lines %
controllers/drain_controller.go 1 5 20.0%
pkg/daemon/daemon.go 7 14 50.0%
Files with Coverage Reduction New Missed Lines %
controllers/drain_controller_helper.go 1 67.43%
controllers/helper.go 2 69.81%
pkg/daemon/daemon.go 5 47.61%
Totals Coverage Status
Change from base Build 18668500198: 0.05%
Covered Lines: 8793
Relevant Lines: 14188

💛 - Coveralls

@nvidia-ci-cd nvidia-ci-cd force-pushed the network-operator-25.10.x branch from 1144951 to ddbec96 Compare October 21, 2025 00:09
…sable SRIOV OP drain controller, in favor of using maintenance OP to drive node drain aspects

Signed-off-by: Ido Heyvi <[email protected]>
…rnal-drainer=true' in case exteranl drainer is enabled

The motivation is for external drainer verification, that SRIOV operator is set with external drainer
Signed-off-by: Ido Heyvi <[email protected]>

drain: adding 'USE_EXTERNAL_DRAINER' provoding an option to enable/disable SRIOV OP drain controller, in favor of using maintenance OP to drive node drain aspects

Signed-off-by: Ido Heyvi <[email protected]>
@heyvister1 heyvister1 force-pushed the disable-drain-controller-forked branch from 3cf43e3 to ba1cabc Compare October 21, 2025 05:08
@heyvister1 heyvister1 merged commit 7b2b696 into Mellanox:network-operator-25.10.x Oct 21, 2025
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants