Skip to content

Conversation

@almaslennikov
Copy link
Collaborator

This flag will enable fw reset after applying nv config. This is required on some DGX server where a warm reboot is not enough to apply the configuration successfully

@coveralls
Copy link

coveralls commented Nov 7, 2025

Pull Request Test Coverage Report for Build 19169491528

Details

  • 6 of 9 (66.67%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.002%) to 46.246%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/controller/nicdevice_controller.go 6 9 66.67%
Files with Coverage Reduction New Missed Lines %
internal/controller/nicfirmwaresource_controller.go 2 81.12%
Totals Coverage Status
Change from base Build 19071895601: -0.002%
Covered Lines: 2981
Relevant Lines: 6446

💛 - Coveralls

This flag will enable fw reset after applying nv config.
This is required on some DGX server where a warm reboot is
not enough to apply the configuration successfully

Signed-off-by: Alexander Maslennikov <[email protected]>
@almaslennikov almaslennikov force-pushed the fw-reset-after-config-update branch from 231b3df to 0240c3d Compare November 7, 2025 13:14
@almaslennikov almaslennikov merged commit dc69fc4 into Mellanox:main Nov 10, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants