Skip to content

Commit a71eb8e

Browse files
authored
fix: remove extra selector from network-operator Deployment (#654)
Remove `control-plane: {{ .Release.Name }}-controller` selector from the network-operator object in the helm chart to fix helm upgrade behaviour. With the current selector we will have the following error when trying to upgrade from the latest GA version (23.7) ``` helm upgrade -n nvidia-network-operator network-operator ./network-operator -f myvalues.yaml Error: UPGRADE FAILED: cannot patch "network-operator" with kind Deployment: Deployment.apps "network-operator" is i nvalid: spec.selector: Invalid value: v1.LabelSelector{MatchLabels:map[string]string{"app.kubernetes.io/instance":"n etwork-operator", "app.kubernetes.io/name":"network-operator", "control-plane":"network-operator-controller"}, Match Expressions:[]v1.LabelSelectorRequirement(nil)}: field is immutable ``` The extra selector was added as a part of #645
2 parents 9890794 + 4d35b6d commit a71eb8e

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

deployment/network-operator/templates/operator.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ spec:
2525
replicas: 1
2626
selector:
2727
matchLabels:
28-
control-plane: {{ .Release.Name }}-controller
2928
{{- include "network-operator.selectorLabels" . | nindent 6 }}
3029
template:
3130
metadata:

0 commit comments

Comments
 (0)