fix: use mofed.wait=false nodeSelector for nic config daemon (#1805)

+ some wording fixes in docs

Author: rollandf

api/v1alpha1/nicclusterpolicy_types.go

@@ -293,7 +293,7 @@ type DOCATelemetryServiceSpec struct {
 // NicFirmwareStorageSpec contains configuration for the NIC firmware storage
 type NicFirmwareStorageSpec struct {
 	// Create specifies whether to create a new PVC or use an existing one
-	// If create == false, the existing PVC should be located in the same namespace as the operator
+	// If create == false, the existing PVC with the name specified in pvcName should be located in the same namespace as the operator
 	// +kubebuilder:default:=true
 	Create bool `json:"create,omitempty"`
 	// PVCName is the name of the PVC to mount as NIC Firmware storage. Default value: "nic-fw-storage-pvc"
@@ -322,7 +322,7 @@ type NicConfigurationOperatorSpec struct {
 	Operator *ImageSpec `json:"operator"`
 	// Image information for nic-configuration-daemon
 	ConfigurationDaemon *ImageSpec `json:"configurationDaemon"`
-	// NicFirmwareStorage contains configuration for the NIC firmware storage
+	// NicFirmwareStorage contains configuration for the NIC firmware storage. If not provided, the NIC firmware storage will not be configured.
 	NicFirmwareStorage *NicFirmwareStorageSpec `json:"nicFirmwareStorage,omitempty"`
 	// LogLevel sets the verbosity level of the logs. info|debug
 	// +kubebuilder:validation:Enum={"info", "debug"}

config/crd/bases/mellanox.com_nicclusterpolicies.yaml

@@ -535,7 +535,8 @@ spec:
                     type: string
                   nicFirmwareStorage:
                     description: NicFirmwareStorage contains configuration for the
-                      NIC firmware storage
+                      NIC firmware storage. If not provided, the NIC firmware storage
+                      will not be configured.
                     properties:
                       availableStorageSize:
                         default: 1Gi
@@ -552,7 +553,7 @@ spec:
                         default: true
                         description: |-
                           Create specifies whether to create a new PVC or use an existing one
-                          If create == false, the existing PVC should be located in the same namespace as the operator
+                          If create == false, the existing PVC with the name specified in pvcName should be located in the same namespace as the operator
                         type: boolean
                       pvcName:
                         default: nic-fw-storage-pvc

deployment/network-operator/crds/mellanox.com_nicclusterpolicies.yaml

@@ -535,7 +535,8 @@ spec:
                     type: string
                   nicFirmwareStorage:
                     description: NicFirmwareStorage contains configuration for the
-                      NIC firmware storage
+                      NIC firmware storage. If not provided, the NIC firmware storage
+                      will not be configured.
                     properties:
                       availableStorageSize:
                         default: 1Gi
@@ -552,7 +553,7 @@ spec:
                         default: true
                         description: |-
                           Create specifies whether to create a new PVC or use an existing one
-                          If create == false, the existing PVC should be located in the same namespace as the operator
+                          If create == false, the existing PVC with the name specified in pvcName should be located in the same namespace as the operator
                         type: boolean
                       pvcName:
                         default: nic-fw-storage-pvc

manifests/state-nic-configuration-operator/070-config-daemon.yaml

@@ -26,6 +26,9 @@ spec:
           operator: Exists
           effect: NoSchedule
       hostNetwork: true
+      nodeSelector:
+        # We need to run it after the DOCA driver is started to be able to successfully configure RoCE settings.
+        network.nvidia.com/operator.mofed.wait: "false"
       hostPID: true
       priorityClassName: system-node-critical
       {{- if .NodeAffinity }}