Merge pull request #390 from kstntnm/feature/4.16.0

[mstlink] Updating help menu and adding war msg

Author: kstntnm

mlxlink/modules/mlxlink_commander.cpp

@@ -3609,6 +3609,14 @@ void MlxlinkCommander::checkPplrCap()
                     supportedLoopbacks.c_str());
         }
     }
+    if (loopBackVal == PHY_REMOTE_LOOPBACK) {
+        string warMsg = "Remote loopback mode pre-request (all should be satisfied):\n";
+        warMsg += "1. Remote loopback is supported only in force mode.\n";
+        warMsg += "   please use the --link_mode_force flag if force mode not configured\n";
+        warMsg += "2. Remote loopback is supported for 25G/50G per lane only.\n";
+        warMsg += "3. If the NIC has 2 ports, please make sure that both ports are in the same speed.";
+        MlxlinkRecord::printWar(warMsg, _jsonRoot);
+    }
 }
 
 void MlxlinkCommander::sendPplr()

mlxlink/modules/mlxlink_ui.cpp

@@ -110,7 +110,7 @@ void MlxlinkUi::printSynopsisCommands()
     MlxlinkRecord::printFlagLine(PTYS_LINK_MODE_FORCE_FLAG_SHORT, PTYS_LINK_MODE_FORCE_FLAG, "",
                   "Configure Link Mode Force (Disable AN)");
     MlxlinkRecord::printFlagLine(PPLR_FLAG_SHORT, PPLR_FLAG, "loopback",
-                  "Configure Loopback Mode [NO(no loopback)/RM(phy remote loopback)/PH(phy loopback)/EX(external loopback)]");
+                  "Configure Loopback Mode [NO(no loopback)/RM(phy remote Rx-to-Tx loopback)/PH(phy Tx-to-Rx loopback)/EX(external Tx-to-Rx loopback)]");
     MlxlinkRecord::printFlagLine(PPLM_FLAG_SHORT, PPLM_FLAG, "fec_override",
                   "Configure FEC [AU(Auto)/NF(No-FEC)/FC(FireCode FEC)/RS(RS-FEC)]");
     printf(IDENT);