Skip to content

Conversation

@MrBr-github
Copy link

@MrBr-github MrBr-github commented Apr 7, 2025

User description

What

Move to media team dedicated service user

Why

Shared user sometimes been abused by other teams causing GitHub token exhaustion
This causes delays in GHPRB plug in response

Issue: HPCINFRA-3444

Change type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

Check list

  • Code follows the style de facto guidelines of this project
  • Comments have been inserted in hard to understand places
  • Documentation has been updated (if necessary)
  • Test has been added (if possible)

PR Type

Enhancement, Other


Description

  • Updated the GitHub Pull Request Builder (GHPRB) configuration to use a dedicated service user.

  • Replaced the shared auth-id with a media team-specific auth-id.

  • Aimed to prevent GitHub token exhaustion caused by shared user abuse.

  • Improved CI reliability by ensuring dedicated authentication credentials.


Changes walkthrough 📝

Relevant files
Configuration changes
opensource_jjb.yaml
Updated GHPRB `auth-id` to dedicated service user               

.ci/opensource_jjb.yaml

  • Replaced auth-id from swx-jenkins5_gh_token to
    svc-nbu-swx-media_GHPRB_ID.
  • Ensured the configuration uses a dedicated service user for GitHub
    authentication.
  • +1/-1     

    Need help?
  • Type /help how to ... in the comments thread for any questions about PR-Agent usage.
  • Check out the documentation for more information.
  • @MrBr-github MrBr-github requested a review from dpressle April 7, 2025 14:36
    @MrBr-github
    Copy link
    Author

    @galnoam please merge

    @galnoam
    Copy link
    Collaborator

    galnoam commented Apr 9, 2025

    Hi @MrBr-github, please change commit title according to convention.
    [CI] Issue: HPCINFRA-3444 Update GHPRB service user

    Shared user sometimes been abused by other teams causing GitHub token exhaustion
    This causes delays in GHPRB plug in response
    
    Move to media team dedicated service user
    
    Signed-off-by: Michael Braverman <[email protected]>
    @MrBr-github
    Copy link
    Author

    Hi @MrBr-github, please change commit title according to convention. [CI] Issue: HPCINFRA-3444 Update GHPRB service user

    @galnoam Done

    @galnoam
    Copy link
    Collaborator

    galnoam commented Apr 14, 2025

    @MrBr-github, CI failed

    @dpressle
    Copy link
    Collaborator

    bot:retest

    @dpressle
    Copy link
    Collaborator

    /describe

    @pr-review-bot-app
    Copy link

    PR Description updated to latest commit (3c826b8)

    @dpressle
    Copy link
    Collaborator

    /review

    @pr-review-bot-app
    Copy link

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 Security concerns

    Sensitive information exposure:
    Ensure that the new auth-id (svc-nbu-swx-media_GHPRB_ID) does not expose sensitive credentials or tokens in the configuration file or logs.

    ⚡ Recommended focus areas for review

    Configuration Update

    Verify that the new auth-id (svc-nbu-swx-media_GHPRB_ID) is correctly configured and has the necessary permissions for the GitHub Pull Request Builder (GHPRB) to function as expected.

    auth-id: 'svc-nbu-swx-media_GHPRB_ID'

    @dpressle
    Copy link
    Collaborator

    @MrBr-github, CI failed

    Ready now

    @dpressle
    Copy link
    Collaborator

    @galnoam please merge

    @dpressle dpressle requested a review from galnoam April 17, 2025 07:27
    @galnoam galnoam merged commit 604fd89 into Mellanox:vNext Apr 23, 2025
    1 check passed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    3 participants