issue: 4409248 Fix RoCE LAG warning

We can not disable RoCE LAG (deprecated option in OFED 5.1).

Signed-off-by: Bashar Abdelgafer <[email protected]>

Author: BasharRadya

src/core/dev/net_device_val.cpp

@@ -1479,8 +1479,7 @@ bool net_device_val::verify_bond_or_eth_qp_creation()
                                           guid_iter->second.front().c_str()) &&
                 check_bond_roce_lag_exist(bond_roce_lag_path, sizeof(bond_roce_lag_path),
                                           guid_iter->second.back().c_str())) {
-                print_roce_lag_warnings(get_ifname_link(), bond_roce_lag_path,
-                                        guid_iter->second.front().c_str(),
+                print_roce_lag_warnings(get_ifname_link(), guid_iter->second.front().c_str(),
                                         guid_iter->second.back().c_str());
             }
         }
@@ -1532,7 +1531,7 @@ bool net_device_val::verify_qp_creation(const char *ifname, enum ibv_qp_type qp_
         nd_logdbg("Cant find ib_ctx for interface %s", base_ifname);
         if (qp_type == IBV_QPT_RAW_PACKET && m_bond != NO_BOND) {
             if (check_bond_roce_lag_exist(bond_roce_lag_path, sizeof(bond_roce_lag_path), ifname)) {
-                print_roce_lag_warnings(get_ifname_link(), bond_roce_lag_path);
+                print_roce_lag_warnings(get_ifname_link());
             } else if ((p_ib_ctx = g_p_ib_ctx_handler_collection->get_ib_ctx(get_ifname_link())) &&
                        strstr(p_ib_ctx->get_ibname(), "bond")) {
                 print_roce_lag_warnings(get_ifname_link());

src/core/util/utils.cpp

@@ -164,8 +164,8 @@ int get_base_interface_name(const char *if_name, char *base_ifname, size_t sz_ba
     return 0;
 }
 
-void print_roce_lag_warnings(const char *interface, char *disable_path /* = NULL */,
-                             const char *port1 /* = NULL */, const char *port2 /* = NULL */)
+void print_roce_lag_warnings(const char *interface, const char *port1 /* = NULL */,
+                             const char *port2 /* = NULL */)
 {
     vlog_printf(VLOG_WARNING,
                 "**********************************************************************************"
@@ -180,14 +180,7 @@ void print_roce_lag_warnings(const char *interface, char *disable_path /* = NULL
     } else {
         vlog_printf(VLOG_WARNING, "* Interface %s will not be offloaded.\n", interface);
         vlog_printf(VLOG_WARNING,
-                    "* " PRODUCT_NAME " cannot offload the device while RoCE LAG is enabled.\n");
-    }
-
-    vlog_printf(VLOG_WARNING, "* Please refer to " PRODUCT_NAME " Release Notes for more info\n");
-
-    if (disable_path) {
-        vlog_printf(VLOG_WARNING, "* In order to disable RoCE LAG please use:\n");
-        vlog_printf(VLOG_WARNING, "* echo 0 > %s\n", disable_path);
+                    "* " PRODUCT_NAME " cannot offload the device; issue with RoCE LAG.\n");
     }
     vlog_printf(VLOG_WARNING,
                 "**********************************************************************************"

src/core/util/utils.h

@@ -255,8 +255,8 @@ size_t get_vlan_base_name_from_ifname(const char *ifname, char *base_ifname, siz
 size_t get_local_ll_addr(const char *ifname, unsigned char *addr, int addr_len, bool is_broadcast);
 
 /* Print warning while RoCE Lag is enabled */
-void print_roce_lag_warnings(const char *interface, char *disable_path = nullptr,
-                             const char *port1 = nullptr, const char *port2 = nullptr);
+void print_roce_lag_warnings(const char *interface, const char *port1 = nullptr,
+                             const char *port2 = nullptr);
 
 /*Print a warning to the user when there was an error registering memory*/
 void print_warning_rlimit_memlock(size_t length, int error);