issue: 4583806 Build fixes in socket redirect and TCP modules

Fix build errors in src/core/sock/sock-redirect.h and
src/core/sock/sockinfo_tcp.cpp by updating declarations and adjusting
dependencies to restore successful compilation.

Signed-off-by: Omri Ritblat <[email protected]>

Author: OmriRitblat

src/core/dev/rfs.cpp

@@ -257,7 +257,7 @@ bool rfs::attach_flow(sockinfo *sink)
             if (!create_flow()) {
                 rfs_logdbg("Failed to create second rule for worker: %d", g_p_app->get_worker_id());
             } else {
-                ("Added second rule to worker: %d", g_p_app->get_worker_id());
+                rfs_logdbg("Added second rule to worker: %d", g_p_app->get_worker_id());
             }
         }
 #endif

src/core/sock/sock-redirect.h

@@ -72,10 +72,9 @@
 #else
 #define XLIO_SYMBOL(_func)   _func
 #define VALID_SYSCALL(_func) ((orig_os_api._func) != nullptr)
-#define SYSCALL(_func, ...)                                                                        \
-    ((VALID_SYSCALL(_func) ? (void)0 : get_orig_funcs()),
 /* coverity[var_deref_op] */
-     orig_os_api._func(__VA_ARGS__))
+#define SYSCALL(_func, ...)                                                                        \
+    ((VALID_SYSCALL(_func) ? (void)0 : get_orig_funcs()), orig_os_api._func(__VA_ARGS__)) /* coverity[var_deref_op] */
 #define SYSCALL_ERRNO_UNSUPPORTED(_func, ...)                                                      \
     (VALID_SYSCALL(_func) ? orig_os_api._func(__VA_ARGS__) : ((errno = EOPNOTSUPP), -1))
 #define XLIO_CALL(_func, ...) _func(__VA_ARGS__)

src/core/sock/sockinfo_tcp.cpp

@@ -2900,7 +2900,7 @@ bool sockinfo_tcp::connect_bind_any_and_check_rules()
 
     if (bound_any_addr) {
         if(unlikely(tcp_bind(&m_pcb, reinterpret_cast<const ip_addr_t *>(&m_bound.get_ip_addr()),
-                 ntohs(m_bound.get_in_port()), m_pcb.is_ipv6)!=0)
+                 ntohs(m_bound.get_in_port()), m_pcb.is_ipv6)!=0))
                  return false;
     }