issue: 4583806 Coverity var_deref_op fixes

Fix Coverity-reported var_deref_op warnings by adding macro-safe Coverity
_Pragma() suppressions inside the SYSCALL wrapper to document intentional
pointer dereferencing and eliminate false positives.

Updated file:
- src/core/sock/sock-redirect.h

Signed-off-by: Omri Ritblat <[email protected]>

Author: OmriRitblat

src/core/sock/sock-redirect.h

@@ -64,18 +64,32 @@
 #include <set>
 
 #ifdef XLIO_STATIC_BUILD
+
 #define XLIO_SYMBOL(_func)                    xlio_##_func
 #define SYSCALL(_func, ...)                   ::_func(__VA_ARGS__)
 #define XLIO_CALL(_func, ...)                 xlio_##_func(__VA_ARGS__)
 #define SYSCALL_ERRNO_UNSUPPORTED(_func, ...) SYSCALL(_func, __VA_ARGS__)
 #define VALID_SYSCALL(_func)                  (true)
 #else
 #define XLIO_SYMBOL(_func)   _func
+#ifdef __COVERITY__
+#define COVERITY_VAR_DEREF_OP \
+    _Pragma("coverity compliance deviate \"var_deref_op\" \
+             \"Intentional dereference; pointer validated elsewhere\"")
+#else
+#define COVERITY_VAR_DEREF_OP
+#endif
+
 #define VALID_SYSCALL(_func) ((orig_os_api._func) != nullptr)
+
 #define SYSCALL(_func, ...)                                                    \
-    ((VALID_SYSCALL(_func) ? (void)0 : get_orig_funcs()),                      \
-     /* coverity[var_deref_op] */                                              \
-     orig_os_api._func(__VA_ARGS__))
+    __extension__({                                                            \
+        if (!VALID_SYSCALL(_func)) {                                           \
+            get_orig_funcs();                                                  \
+        }                                                                      \
+        COVERITY_VAR_DEREF_OP                                                  \
+        orig_os_api._func(__VA_ARGS__);                                        \
+    })
 #define SYSCALL_ERRNO_UNSUPPORTED(_func, ...)                                                      \
     (VALID_SYSCALL(_func) ? orig_os_api._func(__VA_ARGS__) : ((errno = EOPNOTSUPP), -1))
 #define XLIO_CALL(_func, ...) _func(__VA_ARGS__)

src/stats/stats_reader.cpp

@@ -1626,6 +1626,7 @@ void stats_reader_handler(sh_mem_t *p_sh_mem, int pid)
         }
         switch (user_params.print_details_mode) {
         case e_totals:
+            /* coverity[forward_null] */
             num_act_inst =
                 show_socket_stats(p_sh_mem->skt_inst_arr, NULL, p_sh_mem->max_skt_inst_num,
                                   &printed_line_num, &p_sh_mem->mc_info, pid);