[CI] Issue: HPCINFRA-3898 coverity agressiveness and exclude files

Due to PR #312 currently the cov.sh script does not calculate the number
of errors from the scan correctly (the cov-format-errors command fails),
this is due to --exclude-files flag being unique (cant use it twice).

Combine both exclude-files flags to one regex
Add -o pipefail so the task will fail if cov-format fails (failiure was
masked by the pipe commands)
Change --aggressiveness-level to medium

Signed-off-by: NirWolfer <[email protected]>

Author: NirWolfer

contrib/jenkins_tests/cov.sh

@@ -40,12 +40,14 @@ eval "cov-manage-emit --config ${cov_dir}/coverity_config.xml --dir ${cov_build}
 sleep 1
 
 eval "cov-analyze --config ${cov_dir}/coverity_config.xml \
-	--all --aggressiveness-level low \
+	--all --aggressiveness-level medium \
 	--enable-fnptr --fnptr-models --paths 20000 \
 	--disable-parse-warnings \
 	--dir ${cov_build}"
 rc=$(($rc+$?))
 
+echo "rc: $rc"
+
 if [[ "${do_coverity_snapshot}" == true ]]; then
     cov-commit-defects --ssl --on-new-cert trust \
         --url https://coverity.mellanox.com:8443 \
@@ -56,17 +58,19 @@ if [[ "${do_coverity_snapshot}" == true ]]; then
     rc=$(($rc+$?))
 fi
 
-set -eE
+set -eEo pipefail
 
 # Excluded files for the local report generated by command "cov-format-errors":
 #  * /usr/include/.*$ (all standard library issues can't be fixed)
 #  * ${WORKSPACE}/third_party/.* (third party code)
 
 # shellcheck disable=SC2001
-nerrors=$(cov-format-errors --exclude-files '/usr/include/.*$' --exclude-files '${WORKSPACE}/third_party/.*$' \
+nerrors=$(cov-format-errors --exclude-files "(/usr/include/.*$ | ${WORKSPACE}/third_party/.*$)" \
     --dir $cov_build --html-output "$cov_build/output/errors" | awk '/Processing [0-9]+ errors?/ { print $2 }')
 rc=$((rc + nerrors))
 
+echo "nerrors: $nerrors"
+
 index_html=$(cd $cov_build && find . -name index.html | cut -c 3-)
 cov_file="$cov_build/${index_html}"