issue: 1510731 Enhance IPoIB devices validation process

Extend verify_qp_creation() to create steering rule in for
IPoIB devices.

Signed-off-by: Liran Oz <[email protected]>

Author: Liran Oz

src/vma/dev/net_device_val.cpp

@@ -1555,20 +1555,26 @@ bool net_device_val::verify_qp_creation(const char* ifname, enum ibv_qp_type qp_
 
 	qp = vma_ibv_create_qp(p_ib_ctx->get_ibv_pd(), &qp_init_attr);
 	if (qp) {
-		success = true;
-		if (!priv_ibv_query_flow_tag_supported(qp, get_port_from_ifname(base_ifname))) {
-			p_ib_ctx->set_flow_tag_capability(true);
-		}
-		nd_logdbg("verified interface %s for flow tag capabilities : %s", ifname, p_ib_ctx->get_flow_tag_capability() ? "enabled" : "disabled");
+		if (qp_type == IBV_QPT_UD && priv_ibv_create_flow_supported(qp, get_port_from_ifname(base_ifname)) == -1) {
+			nd_logdbg("Create_ibv_flow failed on interface %s (errno=%d %m), Traffic will not be offloaded", ifname, errno);
+			goto qp_failure;
+		} else {
+			success = true;
+			if (qp_type == IBV_QPT_RAW_PACKET && !priv_ibv_query_flow_tag_supported(qp, get_port_from_ifname(base_ifname))) {
+				p_ib_ctx->set_flow_tag_capability(true);
 
+			}
+			nd_logdbg("verified interface %s for flow tag capabilities : %s", ifname, p_ib_ctx->get_flow_tag_capability() ? "enabled" : "disabled");
+		}
 	} else {
-		nd_logdbg("QP creation failed on interface %s (errno=%d %m), Traffic will not be offloaded \n", ifname, errno);
+		nd_logdbg("QP creation failed on interface %s (errno=%d %m), Traffic will not be offloaded", ifname, errno);
+qp_failure:
 		int err = errno; //verify_raw_qp_privliges can overwrite errno so keep it before the call
 		if (validate_raw_qp_privliges() == 0) {
 			// MLNX_OFED raw_qp_privliges file exist with bad value
 			vlog_printf(VLOG_WARNING,"*******************************************************************************************************\n");
 			vlog_printf(VLOG_WARNING,"* Interface %s will not be offloaded.\n", ifname);
-			vlog_printf(VLOG_WARNING,"* Working in this mode might causes VMA malfunction over Ethernet interfaces\n");
+			vlog_printf(VLOG_WARNING,"* Working in this mode might causes VMA malfunction over Ethernet/InfiniBand interfaces\n");
 			vlog_printf(VLOG_WARNING,"* WARNING: the following steps will restart your network interface!\n");
 			vlog_printf(VLOG_WARNING,"* 1. \"echo options ib_uverbs disable_raw_qp_enforcement=1 > /etc/modprobe.d/ib_uverbs.conf\"\n");
 			vlog_printf(VLOG_WARNING,"* 2. Restart openibd or rdma service depending on your system configuration\n");

src/vma/util/verbs_extra.cpp

@@ -317,6 +317,37 @@ int priv_ibv_query_flow_tag_supported(struct ibv_qp *qp, uint8_t port_num)
 	return res;
 }
 
+int priv_ibv_create_flow_supported(struct ibv_qp *qp, uint8_t port_num)
+{
+	int res = -1;
+
+	struct __attribute__ ((packed)) {
+		vma_ibv_flow_attr             attr;
+		vma_ibv_flow_spec_ipv4        ipv4;
+		vma_ibv_flow_spec_tcp_udp     tcp_udp;
+	} cf_attr;
+
+	// Initialize
+	memset(&cf_attr, 0, sizeof(cf_attr));
+	cf_attr.attr.size = sizeof(cf_attr);
+	cf_attr.attr.num_of_specs = 2;
+	cf_attr.attr.type = VMA_IBV_FLOW_ATTR_NORMAL;
+	cf_attr.attr.priority = 1; // almost highest priority, 0 is used for 5-tuple later
+	cf_attr.attr.port = port_num;
+
+	ibv_flow_spec_ipv4_set(&cf_attr.ipv4, INADDR_LOOPBACK, INADDR_LOOPBACK); // L3 filter
+	ibv_flow_spec_tcp_udp_set(&cf_attr.tcp_udp, true, 0, 0); // L4 filter
+
+	// Create flow
+	vma_ibv_flow *ibv_flow = vma_ibv_create_flow(qp, &cf_attr.attr);
+	if (ibv_flow) {
+		res = 0;
+		vma_ibv_destroy_flow(ibv_flow);
+	}
+
+	return res;
+}
+
 int vma_rdma_lib_reset() {
 #ifdef HAVE_RDMA_LIB_RESET
 	vlog_printf(VLOG_DEBUG, "rdma_lib_reset called\n");

src/vma/util/verbs_extra.h

@@ -111,6 +111,7 @@ void priv_ibv_modify_cq_moderation(struct ibv_cq* cq, uint32_t period, uint32_t
 
 #define FLOW_TAG_MASK     ((1 << 20) -1)
 int priv_ibv_query_flow_tag_supported(struct ibv_qp *qp, uint8_t port_num);
+int priv_ibv_create_flow_supported(struct ibv_qp *qp, uint8_t port_num);
 
 /* DEFINED_VERBS_VERSION:
  * 1 - Legacy Verbs API