hw-mgmgt: thermal: TC add config parameters validation.

TC add config parameters validation for module

FR: 4448446

Signed-off-by: Oleksandr Shamray <[email protected]>

Author: sholeksandr

usr/usr/bin/hw_management_thermal_control_2_5.py

@@ -242,6 +242,37 @@ class CONST(object):
     avg = avg_acc / input_smooth_level
 """
 
+SENSOR_PARAM_RANGE = {
+    r'module\d+': {
+        "val_min_offset": {
+            "min": -30000,
+            "max": -5000,
+        },
+        "val_max_offset": {
+            "min": -30000,
+            "max": 0,
+        },
+        "pwm_min": {
+            "min": 20,
+            "max": 100,
+        },
+        "pwm_max": {
+            "min": 30,
+            "max": 100,
+        }
+    },
+    r'.*': {
+        "pwm_min": {
+            "min": 20,
+            "max": 100,
+        },
+        "pwm_max": {
+            "min": 30,
+            "max": 100,
+        }
+    }
+}
+
 # fmt: off
 SENSOR_DEF_CONFIG = {
     r'psu\d+_fan':      {"type": "psu_fan_sensor",
@@ -1340,6 +1371,13 @@ def start(self):
         self.log.info("Starting {}".format(self.name))
         self.pwm_min = int(self.sensors_config.get("pwm_min", CONST.PWM_MIN))
         self.pwm_max = int(self.sensors_config.get("pwm_max", CONST.PWM_MAX))
+        if not self.validate_sensor_param("pwm_min", self.pwm_min):
+            self.log.error("{}: pwm_min incorrect value ({})".format(self.name, self.pwm_min), 1)
+            raise ValueError("Incorrect value of pwm_min {}".format(self.pwm_min))
+        if not self.validate_sensor_param("pwm_max", self.pwm_max):
+            self.log.error("{}: pwm_max incorrect value ({})".format(self.name, self.pwm_max), 1)
+            raise ValueError("Incorrect value of pwm_max {}".format(self.pwm_max))
+
         self.pwm_regulator.update_param(self.val_min, self.val_max, self.pwm_min, self.pwm_max)
         self.refresh_attr_period = self.sensors_config.get("refresh_attr_period", 0)
         if self.refresh_attr_period:
@@ -1563,6 +1601,37 @@ def read_val_min_max(self, filename, trh_type, scale=1):
         self.log.debug("Set {} {} : {}".format(self.name, trh_type, val))
         return val
 
+    # ----------------------------------------------------------------------
+    def validate_sensor_param(self, param_name, param_value):
+        """
+        @summary: Validate sensor parameter value
+        """
+        if not isinstance(param_value, (int, float)):
+            self.log.error("{}: {} value({}) is not a number".format(self.name, param_name, param_value), repeat=1)
+            return False
+        param_value = float(param_value)
+        for sensor_name_mask, sensor_param_list in SENSOR_PARAM_RANGE.items():
+            if re.match(sensor_name_mask, self.name):
+                if param_name in sensor_param_list:
+                    param_value_range = sensor_param_list[param_name]
+                    if "min" in param_value_range:
+                        if param_value < param_value_range["min"]:
+                            self.log.info("{}: {} value({}) is out of range({}-{})".format(self.name,
+                                                                                           param_name,
+                                                                                           param_value,
+                                                                                           param_value_range["min"],
+                                                                                           param_value_range["max"]))
+                            return False
+                    if "max" in param_value_range:
+                        if param_value > param_value_range["max"]:
+                            self.log.info("{}: {} value({}) is out of range({}-{})".format(self.name,
+                                                                                           param_name,
+                                                                                           param_value,
+                                                                                           param_value_range["min"],
+                                                                                           param_value_range["max"]))
+                            return False
+        return True
+
     # ----------------------------------------------------------------------
     def check_sensor_blocked(self, name=None):
         """
@@ -1831,6 +1900,25 @@ def __init__(self, cmd_arg, sys_config, name, tc_logger):
         self.scale = CONST.TEMP_SENSOR_SCALE / scale_value
         self.val_lcrit = self.read_val_min_max(None, "val_lcrit", self.scale)
         self.val_hcrit = self.read_val_min_max(None, "val_hcrit", self.scale)
+
+        self.pwm_min = float(self.sensors_config.get("pwm_min", CONST.PWM_MIN))
+        self.pwm_max = float(self.sensors_config.get("pwm_max", CONST.PWM_MAX))
+        if not self.validate_sensor_param("pwm_min", self.pwm_min):
+            self.log.error("{}: pwm_min incorrect value ({})".format(self.name, self.pwm_min), repeat=1)
+            raise ValueError("Incorrect value of pwm_min {}".format(self.pwm_min))
+        if not self.validate_sensor_param("pwm_max", self.pwm_max):
+            self.log.error("{}: pwm_max incorrect value ({})".format(self.name, self.pwm_max), repeat=1)
+            raise ValueError("Incorrect value of pwm_max {}".format(self.pwm_max))
+
+        self.val_min_offset = self.sensors_config.get("val_min_offset", 0)
+        self.val_max_offset = self.sensors_config.get("val_max_offset", 0)
+        if not self.validate_sensor_param("val_min_offset", self.val_min_offset):
+            self.log.error("{}: val_min_offset incorrect value ({})".format(self.name, self.val_min_offset), repeat=1)
+            raise ValueError("Incorrect value of val_min_offset {}".format(self.val_min_offset))
+        if not self.validate_sensor_param("val_max_offset", self.val_max_offset):
+            self.log.error("{}: val_max_offset incorrect value ({})".format(self.name, self.val_max_offset), repeat=1)
+            raise ValueError("Incorrect value of val_max_offset {}".format(self.val_max_offset))
+
         self.refresh_attr()
 
     # ----------------------------------------------------------------------
@@ -1839,14 +1927,10 @@ def refresh_attr(self):
         @summary: refresh sensor attributes.
         @return None
         """
-        self.pwm_min = float(self.sensors_config.get("pwm_min", CONST.PWM_MIN))
-        self.pwm_max = float(self.sensors_config.get("pwm_max", CONST.PWM_MAX))
-        val_min_offset = self.sensors_config.get("val_min_offset", 0)
-        val_max_offset = self.sensors_config.get("val_max_offset", 0)
         val_max = self.read_val_min_max("thermal/{}_temp_crit".format(self.base_file_name), "val_max", scale=self.scale)
         if val_max != 0:
-            self.val_min = val_max + val_min_offset / self.scale
-            self.val_max = val_max + val_max_offset / self.scale
+            self.val_max = val_max + self.val_max_offset / self.scale
+            self.val_min = self.val_max + self.val_min_offset / self.scale
         else:
             self.val_max = 0.0
             self.val_min = 0.0