Skip to content

Commit cdc3cbf

Browse files
committed
fix date parsing bug 🚑
1 parent 2ebb0dd commit cdc3cbf

File tree

7 files changed

+6
-6
lines changed

7 files changed

+6
-6
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ DB_CONNECTION = models.Connection('sqlite:///pandas_oop.db') # this is the same
2525
class People(models.DataFrame):
2626
name = StringColumn(unique=True)
2727
age = IntegerColumn()
28-
money = FloatColumn()
28+
money = FloatColumn(target_name="coins") # target_name if the name in the csv or table is coins and you want to have a different variable name
2929
insertion_date = DateColumn(format='%d-%m-%Y')
3030
is_staff = BoolColumn(true='yes', false='no')
3131
```

db/migrations.db

0 Bytes
Binary file not shown.

db/pandas_oop.db

0 Bytes
Binary file not shown.

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
setuptools.setup(
77
name="pandas-oop",
8-
version="0.9.3",
8+
version="0.9.4",
99
author="Mayas Nova",
1010
author_email="[email protected]",
1111
description="Pandas dataframes with object oriented programming style",

src/pandas_oop/models.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -203,9 +203,9 @@ def _validate_kwargs(self, func=None, **kwargs):
203203

204204
if data_type.str_type == 'datetime64[ns]':
205205
if 'parse_dates' in kwargs.keys():
206-
kwargs['parse_dates'].append(data_type.name)
206+
kwargs['parse_dates'].append(data_type.target_name)
207207
else:
208-
kwargs['parse_dates'] = [data_type.name]
208+
kwargs['parse_dates'] = [data_type.target_name]
209209
continue
210210

211211
if data_type.str_type == 'bool' and data_type.col_obj_series.true_or_false is not None:

tests/test_dataframe_behavior.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ def test_populate_from_iterator(self):
123123

124124
def test_dataframe_has_column_name_declared(self):
125125
people = PeopleDeclaredWithDifferentFields(from_csv=PEOPLE_DATA_FILE, delimiter=";")
126-
self.assertEqual(list(people.columns), ['name_test', 'age', 'money_test', 'insertion_date', 'is_staff'])
126+
self.assertEqual(list(people.columns), ['name_test', 'age', 'money_test', 'insertion_date_test', 'is_staff'])
127127

128128
def setUp(self):
129129
# Old school creation

tests/test_models_declaration.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ class PeopleDeclaredWithDifferentFields(models.DataFrame):
9494
name_test = StringColumn(target_name='name')
9595
age = IntegerColumn()
9696
money_test = FloatColumn(target_name='money')
97-
insertion_date = DateColumn()
97+
insertion_date_test = DateColumn(target_name="insertion_date")
9898
is_staff = BoolColumn()
9999

100100

0 commit comments

Comments
 (0)