Errors hidden

[psh-baxter]

Currently in unmarshall it tries to read the error into an APIError struct but if it doesn't match the error text is lost forever.

It would be nice if

1. The APIError struct matched the error json (I'm not sure if this applies to just some error responses or what)
2. If deserialization fails there the raw body text is available to client libraries

Error json payloads are unlikely to be large so I don't think deserialization needs to happen directly from the body reader, it could be buffered entirely up front.

[psh-baxter]

Here's an example 403 that wasn't deserializing:

{
  "error": {
    "title": "Forbidden",
    "message": "Unverified email address"
  }
}

[eggman64]

Thanks for reporting this and adding your suggestion. We will look into it

[eggman64]

@psh-baxter I looked into this and it appears that the APIError struct follows the API error response from Zendesk's API docs here.

Will dump the original response if we can't parse it