Skip to content

add donation button to the sidebar #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

namiroues
Copy link
Contributor

The webpage will look like this with this change. (The pages are reordered appropriately in #458).

I am happy to hear suggestions regarding the text and button (if it stays or should be removed) on the landing and funding pages.

Screenshot 2025-04-10 at 11 29 12

@namiroues
Copy link
Contributor Author

This PR fixes #462.

Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My main concern with adding content to the sidebar is that because it's fixed and not scrollable, you cannot access certain parts on small screens/browser windows. It's a limitation of the simple design template that we used. See #310 .

I overall like the idea of making donating visible.

Perhaps play around with how the sidebar behaves ... I think it had something to do with the :sticky-sidebar"

position: absolute;

(EDIT: I think there was a way to switch the behavior in the Hyde theme somehow. Alternatively, slim down the sidebar menu to make space.)

@namiroues
Copy link
Contributor Author

Thanks @orbeckst. I tested the sidebar after adding the donate button, and it scrolls properly on small screens (see attached screenshot from iPhone). The button stays visible but doesn’t obstruct any content.

iphone_sidebar

Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, if you say it works then I am happy.

@micaela-matta micaela-matta merged commit ffd1196 into MDAnalysis:master Apr 15, 2025
1 check passed
@namiroues namiroues deleted the add-donation-button-to-sidebar branch May 23, 2025 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SDG23 work on Small Development Grant 2023
Development

Successfully merging this pull request may close these issues.

3 participants