"check" command is deprecated. Seems that "scan" command offers a replacement

[thorroed]

upstream safety maintainers decided to deprecate the "check" command.

The following output is currently generated:

...
DEPRECATED: this command (check) has been DEPRECATED, and will be unsupported beyond 01 June 2024.

We highly encourage switching to the new scan command which is easier to use, more powerful, and can be set up to mimic the deprecated command if required.
...

[Lucas-C]

Thank you for the heads up @thorroed 👍

[Lucas-C]

It seems that the new scan command does not support the --file parameter anymore.
The closest equivalent is --target, that must be a project directory, not a requirements.txt file.

The --ignore parameter also does not exist in the new scan command.

This means that some refactoring works need to be undertaken.
I do not have the time to do this in the the foreseeable future, but I would be happy to merge PRs adding support for the scan command to this pre-commit hook.

Maybe the simplest solution would be to expose a second hook, python-safety-dependencies-scan.

[Lucas-C]

If the warning is annoying you, you can restrict the version of safety to be <=2.3.5:

safety<=2.3.5

[ev-agelos]

How? I mean your code depends on safety except if you mean to fork? Shouldnt you restrict it in your code, otherwise whoever uses your code it will fail anyway
Sorry i thought it was an error instead of warning

[adrienbanse]

Hey @Lucas-C, sorry to bother, but even if I change my safety version, I still get the same exception as #61, and therefore my hook fails

Is there something I'm doing wrong here?

[Lucas-C]

Hey @Lucas-C, sorry to bother, but even if I change my safety version, I still get the same exception as #61, and therefore my hook fails

Is there something I'm doing wrong here?

Are you refering to the changes in PR mlco2/ecologits#139?
If so, I do not see safety version pinned to safety<=2.3.5 anywhere on this branch/repo...

And if it's not related to this PR, could you specify a fully, autonomous, minimal reproducible example please?

[adrienbanse]

Sorry I tried locally. I just added the requirement in the PR (which is then the reproducible example).

[Lucas-C]

Thanks @adrienbanse

I made a new release: https://github.com/Lucas-C/pre-commit-hooks-safety/releases/tag/v1.4.1

Could you test if that solves you issue?

[adrienbanse]

Works well, many thanks @Lucas-C 💪

cc @Rakeshmn1993