Incorrect autocomplete

[Leadwerks]

How are you using the lua-language-server?

Visual Studio Code Extension (sumneko.lua)

Which OS are you using?

Windows

What is the issue affecting?

Completion

Expected Behaviour

This occurs in both the Visual Studio Code integration, and in my own application using the command line.

Here is a simple example that shows three wrong suggestions.

Actual Behaviour

I would not expect this situation to show any suggestions here.

Reproduction steps

Type this in a VSCode Lua file, with the caret at the end:

t = {}
t.position=3
t.affect = "test"
t.position.

Additional Notes

No response

Log File

No response

[CppCXY]

it is vscode words completion

[Leadwerks]

No, this happens in our application as well:

[tomlau10]

From the screenshot, the completion kind = 1 => m.CompletionItemKind.Text

lua-language-server/script/proto/define.lua

Lines 54 to 55 in 7dd611a

	m.CompletionItemKind = {
	Text = 1,

By full searching define.CompletionItemKind.Text in LuaLS, this completion kind is controlled by 2 configs:

• lua-language-server/script/core/completion/completion.lua

  Lines 718 to 804 in 7dd611a

  	local function checkCommon(state, word, position, results)
  	local myUri = state.uri
  	local showWord = config.get(state.uri, 'Lua.completion.showWord')
  	if showWord == 'Disable' then
  	return
  	end
  	results.enableCommon = true
  	if showWord == 'Fallback' and #results ~= 0 then
  	return
  	end
  	local used = {}
  	for _, result in ipairs(results) do
  	used[result.label:match '^[^(]*'] = true
  	end
  	for _, data in ipairs(keyWordMap) do
  	used[data[1]] = true
  	end
  	if config.get(state.uri, 'Lua.completion.workspaceWord') and #word >= 2 then
  	local myHead = word:sub(1, 2)
  	for uri in files.eachFile(state.uri) do
  	if #results >= 100 then
  	results.incomplete = true
  	break
  	end
  	if myUri == uri then
  	goto CONTINUE
  	end
  	local words = files.getWordsOfHead(uri, myHead)
  	if not words then
  	goto CONTINUE
  	end
  	for _, str in ipairs(words) do
  	if #results >= 100 then
  	break
  	end
  	if not used[str]
  	and str ~= word then
  	used[str] = true
  	if matchKey(word, str) then
  	results[#results+1] = {
  	label = str,
  	kind = define.CompletionItemKind.Text,
  	}
  	end
  	end
  	end
  	::CONTINUE::
  	end
  	for uri in files.eachDll() do
  	if #results >= 100 then
  	break
  	end
  	local words = files.getDllWords(uri) or {}
  	for _, str in ipairs(words) do
  	if #results >= 100 then
  	break
  	end
  	if #str >= 3 and not used[str] and str ~= word then
  	used[str] = true
  	if matchKey(word, str) then
  	results[#results+1] = {
  	label = str,
  	kind = define.CompletionItemKind.Text,
  	}
  	end
  	end
  	end
  	end
  	end
  	for str, offset in state.lua:gmatch('(' .. guide.namePattern .. ')()') do
  	if #results >= 100 then
  	results.incomplete = true
  	break
  	end
  	if #str >= 3
  	and not used[str]
  	and guide.offsetToPosition(state, offset - 1) ~= position then
  	used[str] = true
  	if matchKey(word, str) then
  	results[#results+1] = {
  	label = str,
  	kind = define.CompletionItemKind.Text,
  	}
  	end
  	end
  	end
  	end

• completion.showWord: https://luals.github.io/wiki/settings/#completionshowword
• completion.workspaceWord: https://luals.github.io/wiki/settings/#completionworkspaceword

---

They are not incorrect, but just some contextual words suggestions.
I believe you can turn them off in the config if you don't want to see any of them 🤔

• .luarc.json

{
  "completion.showWord": "Disable"
}

• but in vscode, after turning it off, there will still be some contextual words suggestions 😕
  (but the word list is different)
  In this case I believe this is what CppCXY said: it is vscode words completion

[Leadwerks]

Okay, I am just ignoring items with kind = 1.