Remove sigmoid in BinaryPrecisionRecallCurve #3182
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR addresses #3179 by making the use of sigmoid normalization optional in
BinaryPrecisionRecallCurve
. Specifically, it introduces a normalization parameter to _binary_precision_recall_curve_format and disables automatic sigmoid application inBinaryPrecisionRecallCurve
.Changes
Adds a normalization:
Optional[str] = "sigmoid"
argument to _binary_precision_recall_curve_format, allowing users to override the default behavior.Passes normalization=None in
BinaryPrecisionRecallCurve
to preserve raw logits and prevent batch-wise distortion during.update()
calls.Notes
This fix only applies to
BinaryPrecisionRecallCurve
, which is the class I directly encountered issues with.I’ve noticed that other metric classes may also apply sigmoid implicitly in ways that could cause similar inconsistencies across batch-wise updates, but since I have not tested those cases, I am leaving them unchanged to avoid unintended side effects.
📚 Documentation preview 📚: https://torchmetrics--3182.org.readthedocs.build/en/3182/