reservation.start.time.constraint = 'same_day' is not working #1043
Description
[x]: This is a bug and not a question.
[x]: I understand that the best way to resolve this issue is to solve it and propose a Pull Request.
Describe the bug**
The setting parameters 'current' for reservation.start.time.constraint has been replaced to same_day in PR #653. However the new setting is not working and acts as default value. The current value is not working too.
The reason is the same_day is not taken is consideration in Domain/Values/ReservationStartTimeConstraint.php
Also the logic has not changed and the old term current is more representative of the effect of the setting (current reservations can be changed, but not when they are finished).
Additional context**
Specifications
- LibreBooking version (or SHA if using the
developbranch):