Folia support

[LKirillK]

Will folia support be added?

[17:06:53 ERROR]: Error occurred while enabling AFKPlus v3.4.9 (Is it up to date?)
java.lang.UnsupportedOperationException: null
at org.bukkit.craftbukkit.scheduler.CraftScheduler.handle(CraftScheduler.java:517) ~[folia-1.21.6.jar:1.21.6-6-e4b0ae9]
at org.bukkit.craftbukkit.scheduler.CraftScheduler.runTaskTimerAsynchronously(CraftScheduler.java:251) ~[folia-1.21.6.jar:1.21.6-6-e4b0ae9]
at org.bukkit.craftbukkit.scheduler.CraftScheduler.runTaskTimerAsynchronously(CraftScheduler.java:238) ~[folia-1.21.6.jar:1.21.6-6-e4b0ae9]
at org.bukkit.craftbukkit.scheduler.CraftScheduler.runTaskLaterAsynchronously(CraftScheduler.java:189) ~[folia-1.21.6.jar:1.21.6-6-e4b0ae9]
at org.bukkit.craftbukkit.scheduler.CraftScheduler.runTaskAsynchronously(CraftScheduler.java:158) ~[folia-1.21.6.jar:1.21.6-6-e4b0ae9]
at AFKPlus (2).jar/net.lapismc.afkplus.util.core.utils.LapisCoreFileWatcher.start(LapisCoreFileWatcher.java:53) ~[AFKPlus (2).jar:?]
at AFKPlus (2).jar/net.lapismc.afkplus.util.core.utils.LapisCoreFileWatcher.(LapisCoreFileWatcher.java:49) ~[AFKPlus (2).jar:?]
at AFKPlus (2).jar/net.lapismc.afkplus.AFKPlus.onEnable(AFKPlus.java:58) ~[AFKPlus (2).jar:?]
at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:280) ~[folia-api-1.21.6-R0.1-SNAPSHOT.jar:?]
at io.papermc.paper.plugin.manager.PaperPluginInstanceManager.enablePlugin(PaperPluginInstanceManager.java:202) ~[folia-1.21.6.jar:1.21.6-6-e4b0ae9]
at io.papermc.paper.plugin.manager.PaperPluginManagerImpl.enablePlugin(PaperPluginManagerImpl.java:109) ~[folia-1.21.6.jar:1.21.6-6-e4b0ae9]
at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:520) ~[folia-api-1.21.6-R0.1-SNAPSHOT.jar:?]
at org.bukkit.craftbukkit.CraftServer.enablePlugin(CraftServer.java:651) ~[folia-1.21.6.jar:1.21.6-6-e4b0ae9]
at org.bukkit.craftbukkit.CraftServer.enablePlugins(CraftServer.java:607) ~[folia-1.21.6.jar:1.21.6-6-e4b0ae9]
at net.minecraft.server.MinecraftServer.loadWorld0(MinecraftServer.java:785) ~[folia-1.21.6.jar:1.21.6-6-e4b0ae9]
at net.minecraft.server.MinecraftServer.loadLevel(MinecraftServer.java:515) ~[folia-1.21.6.jar:1.21.6-6-e4b0ae9]
at net.minecraft.server.dedicated.DedicatedServer.initServer(DedicatedServer.java:280) ~[folia-1.21.6.jar:1.21.6-6-e4b0ae9]
at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1246) ~[folia-1.21.6.jar:1.21.6-6-e4b0ae9]
at net.minecraft.server.MinecraftServer.lambda$spin$2(MinecraftServer.java:353) ~[folia-1.21.6.jar:1.21.6-6-e4b0ae9]
at java.base/java.lang.Thread.run(Thread.java:1583) ~[?:?]

[Dart2112]

Unfortunately it seems that Folia doesn't support the way I use the BukkitScheduler. That does mean that there will need to be a significant change to the way I schedule tasks as repeating tasks are the basis of this plugin. It is certainly something I want to look into but the documentation available for developers to adapt their plugins seems to be lacking or just poorly laid out as I cant really get a grasp of it at the moment. I'll keep looking around and see what I can do but it might take a while to get an update out for this.

[Dart2112]

Okay, so I might have got it working.
Pushed up an update to LapisCore to support running tasks in both Folia and Bukkit. First test shows it working, but there might be bugs in Folia that I haven't found yet.
https://jenkins.dnablue2112.com/job/AFKPlus/ Build 69 or newer has the required changes. You're welcome to test it and report back. But on my first test it was able to do the basic functions of setting me AFK, warning me, then kicking me.

[LKirillK]

Some errors
[13:51:07 INFO]: hui issued server command: /afk
[13:51:07 INFO]: [AFK] hui сейчас AFK
[13:51:07 ERROR]: Command exception: /afk
java.lang.IllegalStateException: Dispatching command async
at io.papermc.paper.threadedregions.RegionizedServer.ensureGlobalTickThread(RegionizedServer.java:118) ~[folia-1.21.6.jar:1.21.6-6-e4b0ae9]
at org.bukkit.craftbukkit.CraftServer.dispatchCommand(CraftServer.java:1009) ~[folia-1.21.6.jar:1.21.6-6-e4b0ae9]
at org.bukkit.Bukkit.dispatchCommand(Bukkit.java:1116) ~[folia-api-1.21.6-R0.1-SNAPSHOT.jar:?]
at AFKPlus-3.4.9.jar/net.lapismc.afkplus.playerdata.AFKPlusPlayer.lambda$runCommands$1(AFKPlusPlayer.java:520) ~[AFKPlus-3.4.9.jar:?]
at AFKPlus-3.4.9.jar/net.lapismc.afkplus.playerdata.AFKPlusPlayer.runCommands(AFKPlusPlayer.java:529) ~[AFKPlus-3.4.9.jar:?]
at AFKPlus-3.4.9.jar/net.lapismc.afkplus.playerdata.AFKPlusPlayer.startAFK(AFKPlusPlayer.java:218) ~[AFKPlus-3.4.9.jar:?]
at AFKPlus-3.4.9.jar/net.lapismc.afkplus.commands.AFK.toggleAFK(AFK.java:104) ~[AFKPlus-3.4.9.jar:?]
at AFKPlus-3.4.9.jar/net.lapismc.afkplus.commands.AFK.onCommand(AFK.java:57) ~[AFKPlus-3.4.9.jar:?]
at AFKPlus-3.4.9.jar/net.lapismc.afkplus.util.core.commands.LapisCoreCommand.onCommand(LapisCoreCommand.java:195) ~[AFKPlus-3.4.9.jar:?]
at AFKPlus-3.4.9.jar/net.lapismc.afkplus.util.core.commands.LapisCoreCommand.execute(LapisCoreCommand.java:183) ~[AFKPlus-3.4.9.jar:?]
at io.papermc.paper.command.brigadier.bukkit.BukkitCommandNode$BukkitBrigCommand.run(BukkitCommandNode.java:83) ~[folia-1.21.6.jar:1.21.6-6-e4b0ae9]
at com.mojang.brigadier.context.ContextChain.runExecutable(ContextChain.java:73) ~[brigadier-1.3.10.jar:?]
at net.minecraft.commands.execution.tasks.ExecuteCommand.execute(ExecuteCommand.java:30) ~[folia-1.21.6.jar:1.21.6-6-e4b0ae9]
at net.minecraft.commands.execution.tasks.ExecuteCommand.execute(ExecuteCommand.java:13) ~[folia-1.21.6.jar:1.21.6-6-e4b0ae9]
at net.minecraft.commands.execution.UnboundEntryAction.lambda$bind$0(UnboundEntryAction.java:8) ~[folia-1.21.6.jar:1.21.6-6-e4b0ae9]
at net.minecraft.commands.execution.CommandQueueEntry.execute(CommandQueueEntry.java:5) ~[folia-1.21.6.jar:1.21.6-6-e4b0ae9]
at net.minecraft.commands.execution.ExecutionContext.runCommandQueue(ExecutionContext.java:105) ~[folia-1.21.6.jar:1.21.6-6-e4b0ae9]
at net.minecraft.commands.Commands.executeCommandInContext(Commands.java:451) ~[folia-1.21.6.jar:1.21.6-6-e4b0ae9]
at net.minecraft.commands.Commands.performCommand(Commands.java:357) ~[folia-1.21.6.jar:1.21.6-6-e4b0ae9]
at net.minecraft.commands.Commands.performCommand(Commands.java:345) ~[folia-1.21.6.jar:1.21.6-6-e4b0ae9]
at net.minecraft.server.network.ServerGamePacketListenerImpl.performUnsignedChatCommand(ServerGamePacketListenerImpl.java:2347) ~[folia-1.21.6.jar:1.21.6-6-e4b0ae9]
at net.minecraft.server.network.ServerGamePacketListenerImpl.lambda$handleChatCommand$13(ServerGamePacketListenerImpl.java:2320) ~[folia-1.21.6.jar:1.21.6-6-e4b0ae9]
at net.minecraft.server.network.ServerGamePacketListenerImpl.lambda$tryHandleChat$16(ServerGamePacketListenerImpl.java:2479) ~[folia-1.21.6.jar:1.21.6-6-e4b0ae9]
at io.papermc.paper.threadedregions.EntityScheduler.executeTick(EntityScheduler.java:243) ~[folia-1.21.6.jar:1.21.6-6-e4b0ae9]
at net.minecraft.server.MinecraftServer.tickServer(MinecraftServer.java:1659) ~[folia-1.21.6.jar:1.21.6-6-e4b0ae9]
at io.papermc.paper.threadedregions.TickRegions$ConcreteRegionTickHandle.tickRegion(TickRegions.java:407) ~[folia-1.21.6.jar:1.21.6-6-e4b0ae9]
at io.papermc.paper.threadedregions.TickRegionScheduler$RegionScheduleHandle.runTick(TickRegionScheduler.java:418) ~[folia-1.21.6.jar:1.21.6-6-e4b0ae9]
at ca.spottedleaf.concurrentutil.scheduler.SchedulerThreadPool$TickThreadRunner.run(SchedulerThreadPool.java:546) ~[concurrentutil-0.0.3.jar:?]
at java.base/java.lang.Thread.run(Thread.java:1583) ~[?:?]

[Dart2112]

Interesting, not the way I thought they'd handle that but okay. A new version has been pushed to Jenkins and it doesn't seem to have any issues with dispatching commands now.

[LKirillK]

Last build works on folia version 1.21.6

[Dart2112]

If you encounter any more issues, feel free to reopen this issue. Otherwise these changes will roll out in the next update.

[LKirillK]

Error when server stopping build 70
[02:03:42 INFO]: [AFKPlus] Disabling AFKPlus v3.4.9
[02:03:42 WARN]: [AFKPlus] AFKPlus file watcher has stopped, configs wont be reloaded until the server restarts
[02:03:42 ERROR]: Error occurred while disabling AFKPlus v3.4.9
org.bukkit.plugin.IllegalPluginAccessException: Plugin attempted to register task while disabled
at io.papermc.paper.threadedregions.scheduler.FoliaGlobalRegionScheduler.runDelayed(FoliaGlobalRegionScheduler.java:65) ~[folia-1.21.6.jar:?]
at io.papermc.paper.threadedregions.scheduler.FoliaGlobalRegionScheduler.run(FoliaGlobalRegionScheduler.java:53) ~[folia-1.21.6.jar:?]
at io.papermc.paper.threadedregions.scheduler.FoliaGlobalRegionScheduler.execute(FoliaGlobalRegionScheduler.java:46) ~[folia-1.21.6.jar:?]
at AFKPlus-3.4.9 (1).jar/net.lapismc.afkplus.util.core.utils.LapisTaskHandler.runSynchronousTaskNow(LapisTaskHandler.java:102) ~[AFKPlus-3.4.9 (1).jar:?]
at AFKPlus-3.4.9 (1).jar/net.lapismc.afkplus.playerdata.AFKPlusPlayer.runCommands(AFKPlusPlayer.java:525) ~[AFKPlus-3.4.9 (1).jar:?]
at AFKPlus-3.4.9 (1).jar/net.lapismc.afkplus.playerdata.AFKPlusPlayer.stopAFK(AFKPlusPlayer.java:284) ~[AFKPlus-3.4.9 (1).jar:?]
at AFKPlus-3.4.9 (1).jar/net.lapismc.afkplus.AFKPlus.lambda$onEnable$0(AFKPlus.java:70) ~[AFKPlus-3.4.9 (1).jar:?]
at java.base/java.util.HashMap$Values.forEach(HashMap.java:1073) ~[?:?]
at AFKPlus-3.4.9 (1).jar/net.lapismc.afkplus.AFKPlus.lambda$onEnable$1(AFKPlus.java:70) ~[AFKPlus-3.4.9 (1).jar:?]
at java.base/java.util.ArrayList.forEach(ArrayList.java:1596) ~[?:?]
at AFKPlus-3.4.9 (1).jar/net.lapismc.afkplus.util.core.utils.LapisTaskHandler.stopALlTasks(LapisTaskHandler.java:187) ~[AFKPlus-3.4.9 (1).jar:?]
at AFKPlus-3.4.9 (1).jar/net.lapismc.afkplus.AFKPlus.onDisable(AFKPlus.java:80) ~[AFKPlus-3.4.9 (1).jar:?]
at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:286) ~[folia-api-1.21.6-R0.1-SNAPSHOT.jar:?]
at io.papermc.paper.plugin.manager.PaperPluginInstanceManager.disablePlugin(PaperPluginInstanceManager.java:237) ~[folia-1.21.6.jar:1.21.6-6-e4b0ae9]
at io.papermc.paper.plugin.manager.PaperPluginInstanceManager.disablePlugins(PaperPluginInstanceManager.java:161) ~[folia-1.21.6.jar:1.21.6-6-e4b0ae9]
at io.papermc.paper.plugin.manager.PaperPluginManagerImpl.disablePlugins(PaperPluginManagerImpl.java:97) ~[folia-1.21.6.jar:1.21.6-6-e4b0ae9]
at org.bukkit.plugin.SimplePluginManager.disablePlugins(SimplePluginManager.java:541) ~[folia-api-1.21.6-R0.1-SNAPSHOT.jar:?]
at org.bukkit.craftbukkit.CraftServer.disablePlugins(CraftServer.java:624) ~[folia-1.21.6.jar:1.21.6-6-e4b0ae9]
at net.minecraft.server.MinecraftServer.stopServer(MinecraftServer.java:1071) ~[folia-1.21.6.jar:1.21.6-6-e4b0ae9]
at net.minecraft.server.dedicated.DedicatedServer.stopServer(DedicatedServer.java:722) ~[folia-1.21.6.jar:1.21.6-6-e4b0ae9]
at io.papermc.paper.threadedregions.RegionShutdownThread.run(RegionShutdownThread.java:163) ~[folia-1.21.6.jar:1.21.6-6-e4b0ae9]

[LKirillK]

Does not affect the functionality of the plugin

[Dart2112]

I've pushed another build to Jenkins that should fix that.
It's an interesting error, apparently plugins cannot run commands while the server is shutting down on Folia.
So now it simply ignores AFKStop commands while the server is stopping. So be careful with what you AFK start and stop commands are, as the stop command cannot be executed if the player was AFK when the server stopped.

[LKirillK]

Last build works on folia without errors