Skip to content

Commit 4ce030c

Browse files
committed
Add options argument in smartuiSnapshot
1 parent c29eba3 commit 4ce030c

File tree

2 files changed

+9
-11
lines changed

2 files changed

+9
-11
lines changed

packages/sdk-utils/src/smartui.js

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -22,12 +22,9 @@ async function fetchDOMSerializer() {
2222
}
2323
}
2424

25-
async function postSnapshot(snapshotDOM, snapshotName, testType) {
25+
async function postSnapshot(snapshot, testType) {
2626
const data = JSON.stringify({
27-
snapshot: {
28-
dom: snapshotDOM,
29-
name: snapshotName
30-
},
27+
snapshot,
3128
testType
3229
});
3330

packages/selenium-driver/src/smartui.js

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,24 @@
11
const utils = require('@lambdatest/sdk-utils');
22
const pkgName = require('../package.json').name;
33

4-
async function smartuiSnapshot(driver, snapshotName) {
4+
async function smartuiSnapshot(driver, name, options = {}) {
55
// TODO: check if driver is selenium webdriver object
66
if (!driver) throw new Error('An instance of the selenium driver object is required.');
7-
if (!snapshotName) throw new Error('The `snapshotName` argument is required.');
7+
if (!name) throw new Error('The `name` argument is required.');
88
if (!(await utils.isSmartUIRunning())) throw new Error('SmartUI server is not running.');
99
let log = utils.logger(pkgName);
1010

1111
try {
1212
let resp = await utils.fetchDOMSerializer();
1313
await driver.executeScript(resp.body.data.dom);
1414

15-
let { dom } = await driver.executeScript(options => ({
16-
dom: SmartUIDOM.serialize(options)
15+
let { dom, url } = await driver.executeScript(options => ({
16+
dom: SmartUIDOM.serialize(options),
17+
url: document.URL
1718
}), {});
1819

19-
await utils.postSnapshot(dom.html, snapshotName, pkgName);
20-
log.info(`Snapshot captured: ${snapshotName}`);
20+
await utils.postSnapshot({url, name, dom, options}, pkgName);
21+
log.info(`Snapshot captured: ${name}`);
2122
} catch (error) {
2223
throw new Error(error);
2324
}

0 commit comments

Comments
 (0)