Using StringBuilder.Clear instead of creating a new one wasn't really an optimization

Laiteux · Laiteux · commit 512edfe29ff9 · 2020-12-18T18:55:34.000+11:00
We don't have to care about the previous instance anyway since it's being garbage collected
diff --git a/src/Milky/ConsoleManager.cs b/src/Milky/ConsoleManager.cs
@@ -25,11 +25,9 @@ public ConsoleManager(Checker checker)
         /// <param name="suffix">Suffix to add to title, can be useful for uh idk</param>
         public async Task StartUpdatingTitleAsync(TimeSpan updateInterval, bool showFree = true, bool showPercentages = true, string prefix = null, string suffix = null)
         {
-            var title = new StringBuilder();
-
             while (true)
             {
-                title.Clear().Append(prefix).Append(_checker.Info.Status);
+                var title = new StringBuilder().Append(prefix).Append(_checker.Info.Status);
 
                 if (_checker.Info.Status != CheckerStatus.Idle)
                 {

Original file line number	Diff line number	Diff line change
`@@ -25,11 +25,9 @@ public ConsoleManager(Checker checker)`
`25`	`25`	`/// <param name="suffix">Suffix to add to title, can be useful for uh idk</param>`
`26`	`26`	`public async Task StartUpdatingTitleAsync(TimeSpan updateInterval, bool showFree = true, bool showPercentages = true, string prefix = null, string suffix = null)`
`27`	`27`	`{`
`28`		`- var title = new StringBuilder();`
`29`		`-`
`30`	`28`	`while (true)`
`31`	`29`	`{`
`32`		`- title.Clear().Append(prefix).Append(_checker.Info.Status);`
	`30`	`+ var title = new StringBuilder().Append(prefix).Append(_checker.Info.Status);`
`33`	`31`
`34`	`32`	`if (_checker.Info.Status != CheckerStatus.Idle)`
`35`	`33`	`{`