NO MERGE: coverage test

Signed-off-by: Liam Brady <[email protected]>

Author: liambrady

Makefile

@@ -43,6 +43,9 @@ test: test-validate ci-lint
 	sudo -E $(POETRYRUN) mutest tests
 	sudo -E $(POETRYRUN) pytest -s -v --cov=munet --cov-report=xml tests
 
+unit-test:
+	sudo -E $(POETRYRUN) pytest -s -v --cov=munet --cov-report=xml tests/conftest.py tests/control/test_spawn.py
+
 clean:
 	rm -f *.yang coverage.xml err.out ox-rfc.el
 	rm -rf .testtmp/schema

munet/base.py

@@ -682,6 +682,12 @@ async def spawn(
 
             self.logger.debug("%s: expecting: %s", self, patterns)
 
+            if p.fileno() == -1:
+                # XXX PopenSpawn's lack of file descriptor (p.fileno()) causes error
+                # with expect() only when async_=True is set. Is this an upstream issue?
+                logging.error("pexpect.popen_spawn.PopenSpawn causes asyncio errors")
+                assert False
+
             while index := await p.expect(patterns, async_=True):
                 if trace:
                     assert p.match is not None

tests/control/test_spawn.py

@@ -57,6 +57,8 @@ async def test_spawn(unet_share, host, mode, shellcmd):
     unet = unet_share
     if not os.path.exists(shellcmd):
         pytest.skip(f"{shellcmd} not installed skipping")
+    if host == "remote1" and mode == "piped":
+        pytest.skip("Skipping due to asyncio issues")
 
     os.environ["TEST_SHELL"] = shellcmd