Skip to content

Commit 2fba6ba

Browse files
Move publish step out of wheels-build.yaml
Follow-up to NVIDIA#142 (comment)
1 parent 7e46e92 commit 2fba6ba

File tree

3 files changed

+39
-27
lines changed

3 files changed

+39
-27
lines changed

.github/workflows/pr.yaml

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,25 @@ jobs:
7777
build_type: pull-request
7878
script: "ci/build_wheel.sh"
7979
matrix_filter: ${{ needs.compute-matrix.outputs.BUILD_MATRIX }}
80+
# TODO: Remove this job before merging
81+
fake-publish-wheels:
82+
needs: build-wheels
83+
runs-on: ubuntu-latest
84+
steps:
85+
- name: Download sdist
86+
if: "!cancelled()"
87+
uses: actions/download-artifact@v4
88+
with:
89+
name: sdist
90+
path: dist
91+
- name: Download wheel
92+
if: "!cancelled()"
93+
uses: actions/download-artifact@v4
94+
with:
95+
name: wheel
96+
path: dist
97+
- name: List wheels
98+
run: ls dist/
8099
test-wheels:
81100
needs:
82101
- build-wheels

.github/workflows/publish.yaml

Lines changed: 20 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,26 @@ jobs:
4141
build_type: release
4242
script: "ci/build_wheel.sh"
4343
matrix_filter: ${{ needs.compute-matrix.outputs.BUILD_MATRIX }}
44-
upload_to_pypi: true
44+
publish-wheels:
45+
needs: build-wheels
46+
runs-on: ubuntu-latest
47+
steps:
48+
- name: Download sdist
49+
if: "!cancelled()"
50+
uses: actions/download-artifact@v4
51+
with:
52+
name: sdist
53+
path: dist
54+
- name: Download wheel
55+
if: "!cancelled()"
56+
uses: actions/download-artifact@v4
57+
with:
58+
name: wheel
59+
path: dist
60+
- name: Publish wheel
61+
uses: pypa/gh-action-pypi-publish@release/v1
62+
with:
63+
password: ${{ secrets.RAPIDSAI_PYPI_TOKEN }}
4564
build-docs:
4665
needs:
4766
- build-conda

.github/workflows/wheels-build.yaml

Lines changed: 0 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -45,10 +45,6 @@ on:
4545
type: string
4646
default: ''
4747

48-
upload_to_pypi:
49-
type: boolean
50-
required: false
51-
5248
defaults:
5349
run:
5450
shell: bash
@@ -173,25 +169,3 @@ jobs:
173169
with:
174170
name: wheel
175171
path: ${{ env.wheel_path }}
176-
177-
publish:
178-
needs: [build]
179-
runs-on: ubuntu-latest
180-
if: inputs.upload_to_pypi
181-
steps:
182-
- name: Download sdist
183-
if: "!cancelled()"
184-
uses: actions/download-artifact@v4
185-
with:
186-
name: sdist
187-
path: dist
188-
- name: Download wheel
189-
if: "!cancelled()"
190-
uses: actions/download-artifact@v4
191-
with:
192-
name: wheel
193-
path: dist
194-
- name: Publish wheel
195-
uses: pypa/gh-action-pypi-publish@release/v1
196-
with:
197-
password: ${{ secrets.RAPIDSAI_PYPI_TOKEN }}

0 commit comments

Comments
 (0)