GenKthBestPaths: Compare amountOut when amountOutUsd is the same (#214)

Author: thanhqt2002

internal/pkg/usecase/findroute/common/gen_path.go

@@ -229,7 +229,8 @@ func getKthPathAtTokenOut(
 
 func betterAmountOut(nodeA, nodeB *nodeInfo, gasFeeInclude bool) bool {
 	// If we consider gas fee, prioritize node with more AmountUsd
-	if gasFeeInclude {
+	// If amountUsd is the same, compare amountOut regardless of gasFeeInclude
+	if gasFeeInclude && !utils.Float64AlmostEqual(nodeA.tokenAmount.AmountUsd, nodeA.tokenAmount.AmountUsd) {
 		return nodeA.tokenAmount.AmountUsd > nodeB.tokenAmount.AmountUsd
 	}
 	// Otherwise, prioritize node with more token Amount

internal/pkg/usecase/getroute/cache.go

@@ -163,7 +163,7 @@ func (c *cache) setRouteToCache(ctx context.Context, routeSummary *valueobject.R
 
 func (c *cache) getCachePointTTL(amount float64) (time.Duration, bool) {
 	for _, cachePoint := range c.config.TTLByAmount {
-		if float64AlmostEqual(cachePoint.Amount, amount) {
+		if utils.Float64AlmostEqual(cachePoint.Amount, amount) {
 			return cachePoint.TTL, true
 		}
 	}

internal/pkg/usecase/getroute/util.go

@@ -1,11 +1,18 @@
 package utils
 
 import (
+	"math"
 	"math/big"
 
 	"github.com/KyberNetwork/router-service/internal/pkg/constant"
 )
 
+const float64EqualityThreshold = 1e-9
+
+func Float64AlmostEqual(a, b float64) bool {
+	return math.Abs(a-b) <= float64EqualityThreshold
+}
+
 func NewBig10(s string) (res *big.Int) {
 	res, _ = new(big.Int).SetString(s, 10)
 	return res