Refactor: Replace try/except with contextlib.suppress()

[secrett2633]

Description

When the sole purpose is to suppress specific exceptions without any additional error handling logic, Python's standard library provides a more elegant solution: contextlib.suppress(). This approach offers several advantages over traditional try/except blocks that simply pass.

Benefits

• Reduced code complexity: Eliminates boilerplate try/except/pass patterns
• Enhanced readability: Intent is immediately clear - we want to suppress specific exceptions
• Improved maintainability: Less verbose and more declarative approach
• Pythonic style: Follows Python's principle of "explicit is better than implicit"

Refactor Example

Current Implementation

class WebSocket(HTTPConnection):
    # ... other methods ...
    
    async def iter_text(self) -> AsyncIterator[str]:
        try:
            while True:
                yield await self.receive_text()
        except WebSocketDisconnect:
            pass

    async def iter_bytes(self) -> AsyncIterator[bytes]:
        try:
            while True:
                yield await self.receive_bytes()
        except WebSocketDisconnect:
            pass

    async def iter_json(self) -> AsyncIterator[Any]:
        try:
            while True:
                yield await self.receive_json()
        except WebSocketDisconnect:
            pass
    
    # ... other methods ...

Proposed Implementation

import contextlib

class WebSocket(HTTPConnection):
    # ... other methods ...
    
    async def iter_text(self) -> AsyncIterator[str]:
        with contextlib.suppress(WebSocketDisconnect):
            while True:
                yield await self.receive_text()

    async def iter_bytes(self) -> AsyncIterator[bytes]:
        with contextlib.suppress(WebSocketDisconnect):
            while True:
                yield await self.receive_bytes()

    async def iter_json(self) -> AsyncIterator[Any]:
        with contextlib.suppress(WebSocketDisconnect):
            while True:
                yield await self.receive_json()
    
    # ... other methods ...

This refactoring aligns with modern Python idioms and makes the codebase more concise while maintaining the same functionality. The use of contextlib.suppress() clearly communicates that we're intentionally ignoring WebSocketDisconnect exceptions in these iterator methods.

What are your thoughts on this proposed refactoring?

[Kludex]

They don't bring much, and pollute the history.

[secrett2633]

Understood, thanks for the feedback!