Enable void_return code fixer (#3045)

The `void_return` rule was previously disabled due to other broken type
annotations trickling through the inheritance hierarchy and causing it
to choose the wrong annotations. Now that
#3011 is complete, this is no
longer an issue and the `void_return` fixer can be re-enabled.

Author: williamjallen

.php-cs-fixer.dist.php

@@ -32,5 +32,4 @@
     'global_namespace_import' => ['import_classes' => true, 'import_constants' => null, 'import_functions' => null],
     'phpdoc_align' => ['align' => 'left'],
     'declare_strict_types' => false, // TODO: turn this back on.  Currently causes errors...
-    'void_return' => false, // TODO: turn this back on.  Currently causes errors...
 ])->setFinder($finder);

app/Console/Kernel.php

@@ -13,10 +13,8 @@ class Kernel extends ConsoleKernel
 {
     /**
      * Define the application's command schedule.
-     *
-     * @return void
      */
-    protected function schedule(Schedule $schedule)
+    protected function schedule(Schedule $schedule): void
     {
         $schedule->job(new PruneJobs())
             ->hourly()
@@ -42,10 +40,8 @@ protected function schedule(Schedule $schedule)
 
     /**
      * Register the commands for the application.
-     *
-     * @return void
      */
-    protected function commands()
+    protected function commands(): void
     {
         $this->load(__DIR__ . '/Commands');
 

app/Exceptions/Handler.php

@@ -32,10 +32,8 @@ class Handler extends ExceptionHandler
 
     /**
      * Report or log an exception.
-     *
-     * @return void
      */
-    public function report(Throwable $exception)
+    public function report(Throwable $exception): void
     {
         parent::report($exception);
     }

app/Http/Controllers/BuildController.php

@@ -802,7 +802,7 @@ public function build_file(int $build_id, int $file_id): StreamedResponse
             'Content-Type' => 'text/plain',
             'Content-Disposition' => "inline/attachment; filename={$filename}",
         ];
-        return response()->streamDownload(function () use ($fp) {
+        return response()->streamDownload(function () use ($fp): void {
             while (!feof($fp)) {
                 echo fread($fp, 1024);
             }

app/Http/Controllers/DynamicAnalysisController.php

@@ -86,7 +86,7 @@ public function apiViewDynamicAnalysis(): JsonResponse
         DB::table('dynamicanalysis')
             ->where('buildid', '=', $this->build->Id)
             ->orderBy('status', 'desc')
-            ->chunk(50, function ($rows) use (&$dynamic_analyses, &$defect_types, $defect_nice_names) {
+            ->chunk(50, function ($rows) use (&$dynamic_analyses, &$defect_types, $defect_nice_names): void {
                 foreach ($rows as $DA_row) {
                     $dynamic_analysis = [];
                     $dynamic_analysis['status'] = ucfirst($DA_row->status);

app/Http/Controllers/ImageController.php

@@ -18,7 +18,7 @@ public function image(Image $image): StreamedResponse
             abort(404);
         }
 
-        return response()->stream(function () use ($image) {
+        return response()->stream(function () use ($image): void {
             echo $image->Data;
         }, 200, ['Content-type' => $image->Extension]);
     }

app/Http/Controllers/TestController.php

@@ -343,7 +343,7 @@ public function apiTestSummary(): JsonResponse|StreamedResponse
                 $filecontent .= "\n";
             }
 
-            return response()->streamDownload(function () use ($filecontent) {
+            return response()->streamDownload(function () use ($filecontent): void {
                 echo $filecontent;
             }, 'test-export.csv', ['Content-type' => 'text/csv']);
         }

app/Http/Controllers/UserController.php

@@ -431,7 +431,7 @@ public function recoverPassword(): View
                 $text .= "$url\n";
                 $text .= "\n\nGenerated by CDash";
 
-                Mail::raw($text, function ($message) use ($email) {
+                Mail::raw($text, function ($message) use ($email): void {
                     $message->subject('CDash password recovery')
                         ->to($email);
                 });

app/Http/Controllers/ViewTestController.php

@@ -58,7 +58,7 @@ public function fetchPageContent(): JsonResponse|StreamedResponse
             $headers = [
                 'Content-Type' => 'text/csv',
             ];
-            return response()->streamDownload(function () use ($response) {
+            return response()->streamDownload(function () use ($response): void {
                 echo $response;
             }, 'test-export.csv', $headers);
         }

app/Http/Submission/Handlers/BuildHandler.php

@@ -554,7 +554,7 @@ public function endElement($parser, $name): void
         parent::endElement($parser, $name);
     }
 
-    public function text($parser, $data)
+    public function text($parser, $data): void
     {
         $element = $this->getElement();
         if ($this->getParent() === 'BUILD') {