Skip to content

Commit 8e1410a

Browse files
committed
refactor(ui): remove kubectl command footer
Removes the footer panel that displayed the underlying `kubectl` command. - The `_FrameRenderable` class is modified to no longer create the footer panel. - The corresponding test `test_live_frame_tracker_updates_sections` is updated to assert that the footer is `None`.
1 parent 3c04096 commit 8e1410a

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

kubernetes_monitoring.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -773,7 +773,7 @@ def __init__(self, command: str, *renderables: RenderableType) -> None:
773773
self.command = command
774774
self.body_renderables: List[RenderableType] = list(renderables)
775775
self._input_panel = _CommandInputPanel()
776-
self._footer_panel = _command_panel(command)
776+
self._footer_panel: Optional[RenderableType] = None
777777

778778
def __rich_console__(self, console: Console, options): # type: ignore[override]
779779
yield self._input_panel
@@ -786,7 +786,7 @@ def input_panel(self) -> RenderableType:
786786
return self._input_panel
787787

788788
@property
789-
def footer_panel(self) -> RenderableType:
789+
def footer_panel(self) -> Optional[RenderableType]:
790790
return self._footer_panel
791791

792792

tests/test_kubernetes_monitoring.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -214,7 +214,7 @@ def test_live_frame_tracker_updates_sections():
214214
tracker.update(frame_key, renderable, snapshot_markdown=None, input_state="")
215215
assert tracker.section_frames["input"] == ("input", ("hidden", ""))
216216
assert tracker.section_frames["body"] == frame_key
217-
assert tracker.section_frames["footer"] == ("footer", ("cmd-1",))
217+
assert tracker.section_frames["footer"] is None
218218

219219
renderable_updated = kubernetes_monitoring._compose_group(
220220
"cmd-2", Text("body-1")
@@ -223,4 +223,4 @@ def test_live_frame_tracker_updates_sections():
223223
frame_key, renderable_updated, snapshot_markdown=None, input_state=""
224224
)
225225
assert tracker.section_frames["body"] == frame_key
226-
assert tracker.section_frames["footer"] == ("footer", ("cmd-2",))
226+
assert tracker.section_frames["footer"] is None

0 commit comments

Comments
 (0)